Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore dist folder #362

Merged
merged 1 commit into from
Jul 8, 2022
Merged

.gitignore dist folder #362

merged 1 commit into from
Jul 8, 2022

Conversation

NachoSoto
Copy link
Contributor

These are just output files built by tsc.

Also reorganized .gitignore. I only added one line.

These are just output files built by tsc.

Also reorganized `.gitignore`. I only added one line
@NachoSoto NachoSoto requested a review from a team July 8, 2022 17:11
@NachoSoto NachoSoto marked this pull request as ready for review July 8, 2022 17:11
@NachoSoto NachoSoto merged commit 7009ed3 into main Jul 8, 2022
@NachoSoto NachoSoto deleted the ignore-dist branch July 8, 2022 18:22
@vegaro
Copy link
Contributor

vegaro commented Jul 14, 2022

I just noticed this change. These files are the ones that we distribute, take a look at https://github.com/RevenueCat/react-native-purchases/blob/main/package.json#L11

I think it's fine to remove it from the repo because before distributing we always run tsc, but by removing this folder from the repo, the plugin will break for anyone installing from git by pointing to "github:revenuecat/react-native-purchases#main" in their package.json.

I am not sure tho. Did you test installing the plugin from a git repo?

@NachoSoto
Copy link
Contributor Author

That's a good point, I didn't try that. Do we have installation instructions for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants