Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersand in URLs being incorrectly escaped as an HTML entity #10461

Closed
timotheos-firestone opened this issue Apr 16, 2018 · 1 comment
Closed

Comments

@timotheos-firestone
Copy link

Description:

When using Markdown-style links in Rocket Chat, the link generated escapes the ampersands as html entities incorrectly, meaning that clicking on the link will navigate the browser to a modified version of the link, not the actual link intended. The link preview seems correct, but the actual link is not.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.63.1
  • Operating System: Ubuntu 16.04 LTS (4.4.0-119-generic)
  • Deployment Method(snap/docker/tar/etc): SNAP
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled?
  • Node Version: v8.9.4
  • mongoDB Version: v3.2.7

Client Binary

  • Rocket.Chat+ Version 2.10.5
  • Windows 7 Professional x64 Service Pack 1

Steps to Reproduce:

  1. Send the message [Test](https://appdb.winehq.org/objectManager.php?sClass=version&iId=34726)
  2. Click on the link (not the preview link)
    Rocket.Chat link bug

Expected behavior:

Browser should navigate to https://appdb.winehq.org/objectManager.php?sClass=version&iId=34726

Actual behavior:

Browser navigates to https://appdb.winehq.org/objectManager.php?sClass=version&iId=34726 (note & in link) which is actually an entirely different page.

@TwizzyDizzy
Copy link

@rocket-cat close

Closing this, since - if I'm not mistaken - this is a duplicate of #6719.

Cheers
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants