-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown link which url has &
has broken
#6719
Comments
Is this live already? I think I've reproduced it in the demo chat today. Steps to reproduce: Copy and paste this into a rocket chat window:
Expected result: (output html) Let me know if you need more info. |
@rocket-cat close Closibg this, as I cannot reproduce this on latest stable version (0.62.2). Please get back to me with additional details if you think this is still the case and I'll happily reopen :) Cheers |
@TwizzyDizzy: |
@rocket-cat open Just reproduced on 0.63.1. Reopening. Cheers |
Unfortunately, it is the same problem on 0.65.1 |
@rodrigok @sampaiodiego Any update? #7454 and #8318 seem to be related to this. |
@tassoevan can you please test #8318 to make sure it properly fixes this issue? |
As @kaiiiiiiiii said there, it isn't the same issue though it has the same root cause. While working on #11165, I noticed that the current markdown parser need some profound tweaks to render messages reliably. I'll look for suggestions from the community and report to the @RocketChat/frontend team. |
issue still present in 0.69.1 ... very annoying since icinga2 also generates this type of URL's with & in between, so alert url in rocketchat are broken :( |
Issue is sadly still present.. |
I have same problem using api to sen messages - every url been sent to rocketchat have ampersant ( & ) is broken - message is cut just after first occurance of & |
Which markdown parser ( |
Original one |
@starso is this only happening when using the API? |
Yes, If i post message directly with url containing & mark everything is fine. |
I've just tested using the API and it seems to be working fine in version |
Rocket.Chat Version: 0.54.2
Running Instances: 1
DB Replicaset OpLog: Enables
Node Version: v4.7.1
Markdown link which url has
&
has broken.ex:
[url with & has broken](https://demo.rocket.chat/channel/general?test=test&test2=test2)
becomes a link to https://demo.rocket.chat/channel/general?test=test&test2=test2
(
&
is replaced to&
)I think this is because of 590d120.
So I'll try to fix and create PR.
The text was updated successfully, but these errors were encountered: