Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop web browser client incorrectly escapes '&' (ampersand) as HTML entity #17465

Closed
ceefour opened this issue Apr 28, 2020 · 3 comments
Closed
Labels
stat: stale Stale issues will be automatically closed if no activity subj: markdown type: bug

Comments

@ceefour
Copy link
Contributor

ceefour commented Apr 28, 2020

Description:

Ampersand incorrectly escaped by desktop web browser client

Steps to reproduce:

Scenario 1:

  1. Edit the channel description and include "&"

Scenario 2:

  1. Post this message: New RocketChat article: Introducing Rocket.Chat 3.1: Get To Know New Features & Updates

Expected behavior:

& is displayed as &

Actual behavior:

In web client, & is displayed as &

This does not happen with Android mobile app.

Scenario 1:

image

Scenario 2:

image

Server Setup Information:

  • Version of Rocket.Chat Server: 3.1.1
  • Operating System: Ubuntu 18.04
  • Deployment Method: helm
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.16.1
  • MongoDB Version: 4.2.6

Client Setup Information

  • Desktop App or Browser Version: Chrome 81
  • Operating System: Ubuntu 18.04

Additional context

Related to #6719, #6789, #10461

Relevant logs:

@ceefour ceefour changed the title Ampersand incorrectly escaped by desktop web browser client Desktop web browser client incorrectly escapes '&' (ampersand) as HTML entity Apr 28, 2020
@gabriellsh
Copy link
Member

I think this #16481 is supposed to fix it.

@gabriellsh
Copy link
Member

Unfortunately that does not fix the system messages. We are planning on reworking the whole parsing system, as it's proved to cause some problems currently.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Jul 26, 2020
@github-actions github-actions bot closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: stale Stale issues will be automatically closed if no activity subj: markdown type: bug
Projects
None yet
Development

No branches or pull requests

2 participants