This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Sprint 34 Hotfix #6168
Merged
Sprint 34 Hotfix #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
I have a vague recollection that there was also a tern/acorn update - @dangoor, is that right? |
|
@njx There was #6064 but afaik that's not necessary to fix the regression. The Acorn bug itself has existed for several sprints, and it only manifested in weird edge cases like #5847. The nasty regression was purely due to the ScoepManager visit code changing, and that part is 100% fixed by Kevin's #6068. (I think EC is in that same boat: it has #6068 but not #6064). |
|
Looks good. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fixes from:
Also, update version strings to 0.34.1.
Please note that this pull request is merging to a new
sprint-34-hotfixbranch and notmaster.