chore: avoid throw error when update unmounted component #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjun1011
reviewed
Aug 23, 2021
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| it('should no error with class component', () => { |
There was a problem hiding this comment.
should warn with class component ？或者 should not throw error with class component
chenjun1011
reviewed
Aug 23, 2021
| if (process.env.NODE_ENV !== 'production') { | ||
| // Block other render | ||
| Host.__isUpdating = false; | ||
| console.error( |
There was a problem hiding this comment.
是哪个组件调用的， warning 中能透出不
chenjun1011
reviewed
Aug 23, 2021
| @@ -117,6 +129,10 @@ function requestUpdate(component, partialState, callback) { | |||
|
|
|||
| // setState | |||
| if (partialState) { | |||
| // Function Component should force update | |||
| if (component.__isReactiveComponent) { | |||
| internal.__isPendingForceUpdate = true; | |||
There was a problem hiding this comment.
将之前 ReactiveComponent _update 方法中会导致报错的 this[INTERNAL]. __isPendingForceUpdate 移到这个地方
SoloJiang
force-pushed
the
fix/node-destroyed
branch
from
afb049a
to
d86da1e
Compare
|
React remove warning pr: facebook/react#22114 |
chenjun1011
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2198
Before this change
this[INTERNAL].__isPendingForceUpdate = trueAbout this change