[CSharp] Add extra diagnostics and a retry to the C# runtime tests and upgrade the macOS runtime #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanmellor
force-pushed
the
csharp-test-diagnostics
branch
from
894bab8
to
4e4f1ca
Compare
Assert that the dotnet restore / build commands succeeded. If we get a failure at this point, the test is obviously going to fail, and we're masking the error by trying to push on with other commands.
Log the command / stdout / stderr / exit status at three places during the C# runtime tests. At these places we are executing subprocesses, but if those fail we weren't logging the info that we may need to diagnose the problem.
ewanmellor
force-pushed
the
csharp-test-diagnostics
branch
from
4e4f1ca
to
cbb1027
Compare
Switch to .NET Core SDK 1.1.4 for the Travis macOS tests. This is the LTS release at the moment. Issue antlr#2078 is starting to look like a crash (SIGILL) inside the dotnet runtime, so this upgrade may help with that.
ewanmellor
changed the title
Issue antlr#2078 is a crash (SIGILL) inside the dotnet runtime when running on macOS on Travis. This is intermittent, so a retry may help. Retry this specific exit status inside runProcess.
ewanmellor
changed the title
|
This retry has worked. The following Travis test shows the dotnet runtime crashing, and the retry kicking in and the test passing. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2078 is a crash (SIGILL) inside the .NET runtime when running on macOS on Travis. This is intermittent, so a retry may help. Retry this specific exit status inside runProcess.
Log the command / stdout / stderr / exit status at three places during the C# runtime tests. At these places we are executing subprocesses, but if those fail we weren't logging the info that we needed to diagnose the problem.
Print the stack trace if compilation fails.
Assert that test compilation succeeded.
Switch to .NET Core SDK 1.1.4 for the Travis macOS tests. This is the LTS release at the moment. This didn't fix #2078, sadly. I've already seen one SIGILL on 1.1.4. We should upgrade anyway.