Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSharp] Add extra diagnostics and a retry to the C# runtime tests and upgrade the macOS runtime #2124

Merged
merged 5 commits into from
Nov 25, 2017
Merged

[CSharp] Add extra diagnostics and a retry to the C# runtime tests and upgrade the macOS runtime #2124

merged 5 commits into from
Nov 25, 2017

Commits on Nov 12, 2017

  1. [CSharp] Print the stack trace if compilation fails.

    @ewanmellor
    ewanmellor committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    2e0ed50 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. [CSharp] Assert that test compilation succeeded. 

    Assert that the dotnet restore / build commands succeeded.  If we
get a failure at this point, the test is obviously going to fail, and
we're masking the error by trying to push on with other commands.
    @ewanmellor
    ewanmellor committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    0ba9808 View commit details
    Browse the repository at this point in the history

  2. [CSharp] Add extra diagnostics to the C# runtime tests. 

    Log the command / stdout / stderr / exit status at three places
during the C# runtime tests.

At these places we are executing subprocesses, but if those fail we
weren't logging the info that we may need to diagnose the problem.
    @ewanmellor
    ewanmellor committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    cbb1027 View commit details
    Browse the repository at this point in the history

  3. [CSharp] Switch Travis / macOS to .NET Core 1.1.4. 

    Switch to .NET Core SDK 1.1.4 for the Travis macOS tests.  This is
the LTS release at the moment.

Issue antlr#2078 is starting to look like a crash (SIGILL) inside the dotnet
runtime, so this upgrade may help with that.
    @ewanmellor
    ewanmellor committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    84eca87 View commit details
    Browse the repository at this point in the history

  4. [CSharp] Add a retry if we get SIGILL when running dotnet. 

    Issue antlr#2078 is a crash (SIGILL) inside the dotnet runtime when running on
macOS on Travis.  This is intermittent, so a retry may help.  Retry this
specific exit status inside runProcess.
    @ewanmellor
    ewanmellor committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    22337f3 View commit details
    Browse the repository at this point in the history