Assign token names to string literals in parse rule contexts #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm...well, this would have to be implemented in all other targets optimally. I am not sure diverging even more with Java target is worth the increased value. |
|
It works for all targets for now. But I'll test it on our big grammars set ASAP. |
|
Oh, i get it. it doesn't change code gen, it just makes it look like the token ref had a label. ok. please do test on a few big grammars. thanks. |
…F. Add getRuleTokens method
…rrect processing of arrays of string literals
… AssignTokenNamesToStringLiteralArraysInGeneratedParserRuleContexts unit-tests
|
Eventually, I've checked the new version on our grammars-v4 repository on Java runtime. Now I can say that everything is fine and I suggest to merge it :) |
KvanTTT
force-pushed
the
AssignTokenNamesToStringLiteralsInParseRuleContexts
branch
from
8803407
to
2f7c5bf
Compare
hermansje
added a commit
to datacamp/antlr-plsql
that referenced
this pull request
Mar 11, 2019
hermansje
added a commit
to datacamp/antlr-plsql
that referenced
this pull request
Mar 11, 2019
KvanTTT
deleted the
AssignTokenNamesToStringLiteralsInParseRuleContexts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2347