fix #1492 #1494
Closed
fix #1492 #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied definition warnings when build with -Xlog, fix antlr#1492
|
Have you tried the latest ANTLR 4.7.2 with fix antlr/antlr4#2358 that correctly assign token names? |
|
@KvanTTT are we holding this PR until the above question is answered? |
|
Actually not blocking, but it would be useful to know. |
|
Lets wait on an answer |
|
I'm closing this PR because there are a lot of style changes. Moreover, it contains merge conflicts and the original issue already has been fixed by #1600. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace characters with TOKENS definited in PlSqlLexer.g4 to fix implied definition warnings when build with -Xlog, fix #1492