-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++ runtime] Improvements of Vocabulary::fromTokenNames #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit doesn't change the behavior, it contains few small improvements: - prevent useless copy when creating the variable tokenName - avoid to check if tokenName is empty twice - use std::string::empty() instead of creating an empty string to compare with - use std::string::clear() instead of assigning an empty C string to clear a string
IohannRabeson
changed the title
[C++ runtime] Optimizations of Vocabulary::fromTokenNames
[C++ runtime] Improvments of Vocabulary::fromTokenNames
Jun 5, 2020
IohannRabeson
changed the title
[C++ runtime] Improvments of Vocabulary::fromTokenNames
[C++ runtime] Improvements of Vocabulary::fromTokenNames
Jun 5, 2020
mike-lischke
approved these changes
Sep 10, 2020
@IohannRabeson Please pull the branch again and fix the conflict. @parrt After the conflict has been solve this patch can be merged. |
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Oct 4, 2020
…ld error in Cpp runtime test
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Nov 20, 2020
…ld error in Cpp runtime test
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Nov 25, 2020
…ld error in Cpp runtime test
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Nov 27, 2020
…ld error in Cpp runtime test
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Nov 30, 2020
…ld error in Cpp runtime test
felixn
pushed a commit
to felixn/antlr4
that referenced
this pull request
Dec 1, 2020
…ld error in Cpp runtime test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit doesn't change the behavior. It contains few small improvements to the class Vocabulary: