Travis: use newer versions #2908
Conversation
felixn
force-pushed
the
travis-use-newer-versions
branch
3 times, most recently
from
e243d4a
to
36a99ff
Compare
|
@IohannRabeson: The following errors about I can reproduce the errors locally by running (with clang 10): The issue seems to be related to your PR #2839, |
|
Yes I will check that
Le mar. 22 sept. 2020 à 14:51, Felix N <notifications@github.com> a écrit :
… @IohannRabeson <https://github.com/IohannRabeson>:
Could you please take a look at the Travis failures of the Cpp
builds/tests?
https://travis-ci.org/github/antlr/antlr4/builds/728336025
The following errors about dfa::Vocabulary pop up:
In file included from /tmp/BaseCppTest-main-1600443341009/Test.cpp:3:
In file included from /home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/antlr4-runtime.h:126:
/home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/misc/InterpreterDataReader.h:20:5: error: call to implicitly-deleted default constructor of 'dfa::Vocabulary'
InterpreterData() {}; // For invalid content.
^
/home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:25:5: note: explicitly defaulted function was implicitly deleted here
Vocabulary() = default;
^
/home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:185:36: note: default constructor of 'Vocabulary' is implicitly deleted because field '_literalNames' of const-qualified type 'const std::vector<std::string>' (aka 'const vector<basic_string<char> >') would not be initialized
std::vector<std::string> const _literalNames;
^
1 warning and 1 error generated.
In file included from /tmp/BaseCppTest-main-1600443341009/TBaseVisitor.cpp:5:
In file included from /tmp/BaseCppTest-main-1600443341009/TBaseVisitor.h:7:
In file included from /home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/antlr4-runtime.h:32:
In file included from /home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/LexerInterpreter.h:10:
/home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:25:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted]
Vocabulary() = default;
^
/home/felix/src/antlr4/runtime-testsuite/target/classes/Cpp/runtime/src/Vocabulary.h:185:36: note: default constructor of 'Vocabulary' is implicitly deleted because field '_literalNames' of const-qualified type 'const std::vector<std::string>' (aka 'const vector<basic_string<char> >') would not be initialized
std::vector<std::string> const _literalNames;
^
I can reproduce the errors locally by running (with clang 10):
cd runtime-testsuite
mvn -q -Dgroups="org.antlr.v4.test.runtime.category.ParserTests" -Dtest=cpp.TestParserExec test
The issue seems to be related to your PR #2839
<#2839>,
because when I revert to a revision older than your changes (for example
f68c47a
<f68c47a>),
the test runs successfully.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2908 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFHJDELZWAARY7ADBCFMW3SHDW4TANCNFSM4RKZMKWA>
.
|
felixn
force-pushed
the
travis-use-newer-versions
branch
2 times, most recently
from
b86e5c7
to
fb43f64
Compare
felixn
force-pushed
the
travis-use-newer-versions
branch
from
85b90cb
to
607a5be
Compare
|
This is ready to merge, from my point of view. |
|
@felixn The c++ side looks ok to me. That said I never been able to reproduce the behavior you mentioned before though, with clang 10 or g++, either on OSX or on Linux. |
Hi, I don't think we're ok with the scope of changes in travis build. |
|
Thanks for the feedback. I wasn't sure what the right scope of changes was, so I started with "upgrade everything" as it's easy to roll back as requested ;) Ideally, we'd test every target both with "oldest supported" and with "newest released", but that's a lot of additional testing. So how about we only upgrade the linux c++ target, that way we have a mix of java8 (non-c++ targets) and java11 (linux c++ target)? |
|
We've seen similar errors before and added fixes. I'm surprised you found more of that. But the fix seems ok. However, I guess @parr is already through the release process and hence this fix won't make it into the 4.9 release. |
|
Actually, I think we only require java7. Can we fix C++ w/o touching Java? |
…ld error in Cpp runtime test
felixn
force-pushed
the
travis-use-newer-versions
branch
from
1f751b6
to
a6c613d
Compare
|
Hi @ericvergnaud / @parrt / @mike-lischke : |
|
closing in favor of the new one |
During investigation of #2806 (comment), I noticed that the Cpp runtime tests were failing locally (with clang 10) with the following errors:
The travis builds were not showing the same errors, since they were running with clang-3.7 / g++-5.
This PR updates the Ubuntu version used for the travis builds to focal / 20.04, clang / g++ 10, and openjdk11, php7.4, and python3.8.