Throw when querying non-scalar objects without a selection set. #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
issue-4025-warn-about-missing-selection-set
branch
from
4843bd2
to
523dd2d
Compare
|
@benjamn could we add a test showing this working? Otherwise I think this is a great post read notification to help with some gotchas of not having a full schema! |
jbaxleyiii
approved these changes
Oct 25, 2018
This would have helped diagnose the cause of #4025, which is that query fields with non-scalar types (or list-of-non-scalar types) must have a selection set. In other words, given a schema like type Query { selectedMessageList: [SelectedMessage] } a query like query getSelectedMessageList { selectedMessageList @client } is invalid since it doesn't specify which fields of the SelectedMessage objects should be included in the list.
As requested by @jbaxleyiii: #4038 (comment)
benjamn
force-pushed
the
issue-4025-warn-about-missing-selection-set
branch
from
523dd2d
to
2e70c99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have helped diagnose the cause of #4025, which is that query fields with non-scalar types (or list-of-non-scalar types) must have a selection set.
In other words, given a schema like
a query like
is illegal since it doesn't specify which fields of the
SelectedMessageobjects should be included in the list.This PR prevents the cache from accidentally returning
IdValueobjects by throwing a helpful exception:While the client does not have access to the schema, it is possible to determine if a value that's about to be returned is a non-scalar object.