Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw when querying non-scalar objects without a selection set. #4038

Merged
merged 4 commits into from
Oct 26, 2018
Merged

Throw when querying non-scalar objects without a selection set. #4038

merged 4 commits into from
Oct 26, 2018

Commits on Oct 26, 2018

  1. Throw when querying non-scalar objects without a selection set. 

    This would have helped diagnose the cause of #4025, which is that query
fields with non-scalar types (or list-of-non-scalar types) must have a
selection set.

In other words, given a schema like

  type Query {
    selectedMessageList: [SelectedMessage]
  }

a query like

  query getSelectedMessageList {
    selectedMessageList @client
  }

is invalid since it doesn't specify which fields of the SelectedMessage
objects should be included in the list.
    @benjamn
    benjamn committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    a668a6f View commit details
    Browse the repository at this point in the history

  2. Avoid declaring handleMissing function in execField method.

    @benjamn
    benjamn committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    74c555c View commit details
    Browse the repository at this point in the history

  3. Convert src/__tests__/diffQueryAgainstStore.ts from \r\n to \n endings.

    @benjamn
    benjamn committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    9ad87d4 View commit details
    Browse the repository at this point in the history

  4. Add a regression test for issue #4025 (fixed by PR #4038). 

    As requested by @jbaxleyiii:
#4038 (comment)
    @benjamn
    benjamn committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    2e70c99 View commit details
    Browse the repository at this point in the history