-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cfnspec): fix the cfnspec update #25320
Conversation
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR. Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Unfortunately this merge broke testing for all PRs that followed:
|
Fixed by #25326 |
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR. Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This reverts commit 3fa9079.
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR. Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
chore(cfnspec): fix the cfnspec update (#25320)
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR.
Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license