chore(cfnspec): fix the cfnspec update (#25320) #25494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR. Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The patch file that's in here is unnecessary, and in fact harmful: because the rename it applies is not necessary, it copies `undefined` values into perfectly fine types. Remove patch and add guard rails agains this. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
|
rix0rrr
approved these changes
May 9, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3a3b69e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cfnspec job currently doesn't create a PR anymore, because the validation is wrong, and fails the job that creates the PR.
Do the additional "did types get renamed" validation only at build time in a PR, not in the job that creates the PR, so we get more visibility on the changes and it's easier to pick up the work to fix it.
Co-authored-by: rix0rrr rix0rrr@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license