Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator update emails #201

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Validator update emails #201

merged 3 commits into from
Nov 11, 2022

Conversation

mstone121
Copy link
Contributor

@mstone121 mstone121 commented Nov 11, 2022

Overview

This PR adds email updates that get sent to validators when a boundary shape is submitted.

Closes #162

Demo

Screenshot 2022-11-11 at 2 37 22 PM

Testing Instructions

  • Login as c1@azavea.com
  • Submit a Review
  • Check server console for email message

Also, the staging server might still be on this branch from when I pushed the latest changes. So these steps might work as well:

Checklist

  • fixup! commits have been squashed
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
  • README.md updated if necessary to reflect the changes
  • CI passes after rebase

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested locally, and saw the S3 demo while pairing.

May make changes to our demo accounts to make life easier in #200. This is good for now!

src/django/api/mail.py Outdated Show resolved Hide resolved
Matt Stone added 3 commits November 11, 2022 16:09
The utility and state are used later by either this function or the
send email function used later.

Prefetching submissions fetches all submissions, but we need only the
latest here. Since prefetch involves multiple queries anyway, we might
as well let the `latest_submission` cached property do it because it
will limit it to only one.
@mstone121 mstone121 force-pushed the test/ms/validator-update-emails branch from 30831cc to 8cf46cb Compare November 11, 2022 22:10
@mstone121 mstone121 merged commit 3029aef into develop Nov 11, 2022
@mstone121 mstone121 deleted the test/ms/validator-update-emails branch November 11, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emails: Validator Updates
2 participants