Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Hand Over Action #227

Merged
merged 42 commits into from
Oct 24, 2020
Merged

Object Hand Over Action #227

merged 42 commits into from
Oct 24, 2020

Conversation

af-a
Copy link
Contributor

@af-a af-a commented Mar 12, 2020

Summary of changes

This pull request contains an implementation of a basic hand-over action used in the research and development project titled: "Incorporating Contextual Knowledge Into Human-Robot Collaborative Task Execution". Please refer to this technical report based on the project for more details.

This video demonstrates the action in action :).

TODO before merging

  • Remove unnecessary files
  • Test and validate implementation
  • Clean up code if necessary
  • Implement move_base feature to approach person before handing object over
  • Implement smarter detection of object receiver: picking the nearest detected person

@af-a af-a changed the base branch from kinetic to devel March 12, 2020 13:51
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

…ise the execution of the DMP is weird); fix readme
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@@ -2,12 +2,14 @@
<launch>
<node pkg="mdr_hand_over_action" type="hand_over_action" name="hand_over_server" output="screen">
<param name="move_arm_server" value="move_arm_server" />
<param name="gripper_controller_pkg_name" value="mdr_gripper_controller" />
<param name="move_base_server" value="move_base_server" />
<param name="gripper_controller_pkg_name" value="mas_hsr_gripper_controller" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave mdr_gripper_controller here please (mas_hsr_gripper_controller in the launcher in mas_hsr).

@@ -9,7 +9,7 @@
</include>

<!-- Actions -->
<include file="$(find mdr_find_people)/ros/launch/find_people.launch" />
<include file="$(find mas_hsr_find_people)/ros/launch/find_people.launch" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@alex-mitrevski alex-mitrevski changed the title WIP: Object Hand Over Action Object Hand Over Action Oct 23, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@alex-mitrevski alex-mitrevski merged commit 6d195de into devel Oct 24, 2020
@alex-mitrevski alex-mitrevski deleted the feature/hand-over-action branch October 24, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants