Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When total sum of persisted panel sizes differs from 100, no resize is possible #227

Closed
tsufiev opened this issue Dec 7, 2023 · 1 comment

Comments

@tsufiev
Copy link

tsufiev commented Dec 7, 2023

The issue can be easily reproduced by going to https://react-resizable-panels.vercel.app/examples/persistence and manually altering one of panel percentage sizes inside localStorage's value under PanelGroup:sizes:persistence key.

The tricky question here is how does the app come to such a corrupted state in localStorage? Unfortunately I cannot share any insight at the moment. The only thing I know is that several users came to me complaining about inability to adjust panel sizes and the only thing I found in their browsers were those size discrepancies.

tsufiev pushed a commit to tsufiev/react-resizable-panels that referenced this issue Dec 7, 2023
tsufiev pushed a commit to tsufiev/react-resizable-panels that referenced this issue Dec 7, 2023
bvaughn pushed a commit that referenced this issue Dec 10, 2023
@bvaughn
Copy link
Owner

bvaughn commented Dec 10, 2023

Fixed in #230

@bvaughn bvaughn closed this as completed Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants