Normalize layouts not totalling to 100% #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for this! I've cherry-picked it into the upcoming release branch (#230) |
bvaughn
added a commit
that referenced
this pull request
Dec 13, 2023
Checklist: - [x] Remove pixel size constraints - [x] Replaced `dataAttributes` prop with ...rest (to support all HTMLAttributes) - [x] Review and pull in changes from open PRs: - [x] #228 - [x] #224 - [x] Audit open issues and close ones that are no longer releveant - [x] Remove any unnecessary async initialization logic necessitated by pixel constraints I think this library's feature set is stable enough in my mind for a 1.0 release. It might be controversial but I have decided to cut pixel-based constraints from that release as they added too much complexity to the initialization and validation logic. --------- Co-authored-by: Timur Sufiev <timur.sufiev@revolut.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227