CRM-21764: Recurring Events without Price Set fail to save #11834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you create a PR against 5.0.0 branch as well - I think I'd prefer to merge to the rc if we can confirm it's all good |
|
@eileenmcnaughton |
|
closing as merged via 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Steps to reproduce:
Before
Nothing happens, Event is not really saved. CRM/Core/Page/AJAX/RecurringEntity.php::updateModeAndPriceSet fails because it returns an empty array, causing the save action to fail without any errors or notices.
After
We update price set only if we have any which results in expected response from updateModeAndPriceSet of CRM/Core/Page/AJAX/RecurringEntity.php. Now event details are getting saved as expected.
Agileware Ref: CIVICRM-831