CRM-21764: Recurring Events without Price Set fail to save

[agilewarealok]

Overview

Steps to reproduce:

1. Create a recurring event with a bit of recurrence
2. Edit a specific event, update any field, such as the event description text field
3. Save, select "only this event"

Before

Nothing happens, Event is not really saved. CRM/Core/Page/AJAX/RecurringEntity.php::updateModeAndPriceSet fails because it returns an empty array, causing the save action to fail without any errors or notices.

After

We update price set only if we have any which results in expected response from updateModeAndPriceSet of CRM/Core/Page/AJAX/RecurringEntity.php. Now event details are getting saved as expected.

Agileware Ref: CIVICRM-831

---

• CRM-21764: Recurring Events without Price Set fail to save

[seamuslee001]

Jenkins test this please

[eileenmcnaughton]

test this please

[jusfreeman]

@eileenmcnaughton good to merge?

[eileenmcnaughton]

I haven't had time to test yet :-(

I did spot one thing I think @agilewarealok needs to fix - can you address the file permissions - you shouldn't be changing them. I use

git config core.filemode false

for that - either globally or in the repo

[agilewarealok]

@eileenmcnaughton

Sure I've updated the permissions for this PR and will take care of it in future.

Thanks!

[eileenmcnaughton]

I test this & replicated the bug & verified this fixed it & the changes make sense. Obviously I would prefer to have a unit test but I realise this is a quick turn around fix on a regression & appreciate the fact you did that. I'd also prefer to use a one-line api call over the DAO->find - but I don't think that's a blocker.

Merging - thank you @agilewarealok & @jusfreeman