REF Ensure that getAmount includes 0s in decimal places up to 2 places

[seamuslee001]

Overview

This fixes the test failures on the current 5.37 up merge into master

Before

params of 20.00 gets returned as 20

After

params of 20.00 gets returned a 20.00

ping @eileenmcnaughton this fixed the test failures for me locally does this make sense to you?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Yep agree

[mattwire]

@seamuslee001 @eileenmcnaughton I didn't see this or I'd have commented. Putting the locale function back in there negates the use of filter_var and breaks sites with decimal separator that is not ".". Eg. ","

Something like this would work:

return round(filter_var($params['amount'], FILTER_SANITIZE_NUMBER_FLOAT, FILTER_FLAG_ALLOW_FRACTION), CRM_Utils_Money::getCurrencyPrecision());

[eileenmcnaughton]

Argh - this was supposed to be formatUSLocaleNumericRounded() - somehow in hte confusion we put the wrong function!!!!