Fix internal formatting of monetary values when handling non-decimal currencies

[eileenmcnaughton]

Overview

As @mattwire pointed out on Mattermost, there is a regression in currency formatting. It arises when processing payments (a) with certain payment processors (e.g. Payflow Pro and iATS) and (b) with currencies that do not use decimal (".") notation.

The problem relates to #20074 (esp 78b338e#diff-3d2a990f0b1960f0b3e6671c645e18033883e6d1eaf535b8d19d085b67dde00bR1171).

Before

Currency separators incorrectly applied

After

The only reason to format money at this stage is to ensure there are 2 decimal places - we should be sticking with machine (US) formatting

Technical Details

Comments

@mattwire @seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton Thanks - looks good. It will need backporting to 5.37 where it regressed

[eileenmcnaughton]

@mattwire yep - @totten we should expedite this drop - on the bright side doing the drop yesterday did help someone n the Joomla! channel

[seamuslee001]

merging as per review