Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README #173

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix typo in README #173

merged 1 commit into from
Oct 3, 2024

Conversation

lawther
Copy link
Contributor

@lawther lawther commented Oct 3, 2024

Simple fix for typo in README.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

google-cla bot commented Oct 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lawther
Copy link
Contributor Author

lawther commented Oct 3, 2024

I thought I had already signed the CLA. Fixed now.

Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devoncarew devoncarew merged commit 6fa0560 into dart-lang:master Oct 3, 2024
6 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 4, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

file (https://github.com/google/file.dart/compare/855831c..6842fea):
  6842fea  2024-10-03  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 (google/file.dart#243)

logging (https://github.com/dart-lang/logging/compare/05116e7..6fa0560):
  6fa0560  2024-10-04  lawther  Fix typo in README (dart-lang/logging#173)

mockito (https://github.com/dart-lang/mockito/compare/b66be81..3de6754):
  3de6754  2024-10-03  Googler  Add "topics" to package mockito

tools (https://github.com/dart-lang/tools/compare/42996fd..d4995d4):
  d4995d47  2024-10-02  Hannah Jin  Add more parameters (androidAppId and iosBundleId) in devtools events.  (dart-lang/tools#295)
  e5b699fd  2024-10-02  Devon Carew  Update labeler.yml (dart-lang/tools#597)

webdriver (https://github.com/google/webdriver.dart/compare/b181c9e..accfed5):
  accfed5  2024-10-02  dependabot[bot]  Bump actions/checkout from 4.1.7 to 4.2.0 (google/webdriver.dart#303)
  aa0165f  2024-10-02  Devon Carew  address diagnostics and update to a more recent package:lints (google/webdriver.dart#304)

Change-Id: I1094c34f0fe646e59e7e6f91450fee2eacdee747
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388053
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants