-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more parameters (androidAppId and iosBundleId) in devtools events. #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
I am hesitant to add the |
PDD updates for deep link validation and impact tracking is approved, internal tracker: b/362324447. reopening this PR |
pkgs/unified_analytics/CHANGELOG.md
Outdated
@@ -1,6 +1,7 @@ | |||
## 6.1.4-wip | |||
|
|||
- Fix formatting and remove dependency on `package:intl`. | |||
- Add more parameters (androidAppId and iosBundleId) in devtools events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: use back tics and code references
- Added
androidAppId
andiosBundleId
to theEvent.devtoolsEvent
constructor.
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
pkgs/unified_analytics/lib/src/constants.dart | 💔 Not covered |
pkgs/unified_analytics/lib/src/event.dart | 💚 98 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
unified_analytics | Condition PersistedSurvey GAClient UserProperty |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Package publish validation ✔️
Package | Version | Status |
---|---|---|
package:unified_analytics | 6.1.4 | ready to publish |
package:cli_config | 0.2.1-wip | WIP (no publish necessary) |
package:coverage | 1.9.2 | already published at pub.dev |
package:extension_discovery | 2.1.0 | already published at pub.dev |
package:graphs | 2.3.3-wip | WIP (no publish necessary) |
package:mime | 2.0.0 | already published at pub.dev |
package:oauth2 | 2.0.4-wip | WIP (no publish necessary) |
package:source_map_stack_trace | 2.1.3-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
pkgs/unified_analytics/CHANGELOG.md
Outdated
@@ -1,6 +1,7 @@ | |||
## 6.1.4-wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want this published, you'll need to remove the -wip
from the version here and in the pubspec.
This looks like it's stuck at "3 workflows awaiting approval" |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
The checks have passed! I don't have write access to merge this PR. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. file (https://github.com/google/file.dart/compare/855831c..6842fea): 6842fea 2024-10-03 dependabot[bot] Bump actions/checkout from 4.1.7 to 4.2.0 (google/file.dart#243) logging (https://github.com/dart-lang/logging/compare/05116e7..6fa0560): 6fa0560 2024-10-04 lawther Fix typo in README (dart-lang/logging#173) mockito (https://github.com/dart-lang/mockito/compare/b66be81..3de6754): 3de6754 2024-10-03 Googler Add "topics" to package mockito tools (https://github.com/dart-lang/tools/compare/42996fd..d4995d4): d4995d47 2024-10-02 Hannah Jin Add more parameters (androidAppId and iosBundleId) in devtools events. (dart-lang/tools#295) e5b699fd 2024-10-02 Devon Carew Update labeler.yml (dart-lang/tools#597) webdriver (https://github.com/google/webdriver.dart/compare/b181c9e..accfed5): accfed5 2024-10-02 dependabot[bot] Bump actions/checkout from 4.1.7 to 4.2.0 (google/webdriver.dart#303) aa0165f 2024-10-02 Devon Carew address diagnostics and update to a more recent package:lints (google/webdriver.dart#304) Change-Id: I1094c34f0fe646e59e7e6f91450fee2eacdee747 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388053 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Devtool PR: flutter/devtools#8177
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.