Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 2.19 changes into the main branch #4541

Merged
merged 11 commits into from
Jan 24, 2023
Merged

Integrate 2.19 changes into the main branch #4541

merged 11 commits into from
Jan 24, 2023

Conversation

parlough
Copy link
Member

No description provided.

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can merge on release, thanks @parlough !

Fixes #4361

Changes:

- Added a best practices entry about `--enforce-lockfile` to
[pub/dependencies](https://dart.dev/tools/pub/dependencies#best-practices)
page
- Added `--enforce-lockfile` to
[pub-get#options](https://dart.dev/tools/pub/cmd/pub-get#options)
section
- Adjusted the
[pub/glossary#lockfile](https://dart.dev/tools/pub/glossary#lockfile)
section to discuss content hashing
- Adjusted the
[pub/versioning#lockfiles](https://dart.dev/tools/pub/versioning#lockfiles)
section to discuss content hashing

Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
MaryaBelanger and others added 10 commits January 24, 2023 10:15
`--legacy-packages-file` is completely de-supported in 2.19.

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
This page obviously needs a lot of work, so I didn't update any of the
conceptual content or any other dart syntax stuff _except_ what is
directly related to changing the examples to using `runZonedGuarded`.

Full page update is tracked here:
#4348

Closes #4224

Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Updates 'Concurrency in Dart' page for `Isolate.run`.

Closes #3904

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Fixes #4318

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Fixes #4314

Changes:

- Added [code
sample](https://dart.dev/guides/language/effective-dart/documentation#consider-writing-a-library-level-doc-comment)
to existing library-level doc comment section
- Added [Don't use library directives unless attaching doc comments or
annotations](https://dart.dev/guides/language/effective-dart/usage#dont-use-library-directives-unless-attaching-doc-comments-or-annotations)
section
- Added [Don't explicitly name
libraries](https://dart.dev/guides/language/effective-dart/usage#dont-explicitly-name-libraries)
section
- Reduced [`part
of`](https://dart.dev/guides/language/effective-dart/usage#do-use-strings-in-part-of-directives)
section
- Removed / modified unnecessary notes about the library directive on
the [Creating
packages](https://dart.dev/guides/libraries/create-library-packages) page

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
…4460)

- Updates lower SDK constraint for examples which use 2.19 features
- Removes ignores related to those elements missing
- Remove the `undefined_annotation` ignore in `docs_good.dart` by adding
a stub of the used annotation to the file
- Removes a duplicate "syntax"

Fixes #4394
Move the mention of Flutter's `compute` function to after introducing
`Isolate.run` and adjust the guidance around when to use it in terms of
`Isolate.run`.

Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 531a186):

https://dart-dev--pr4541-2-19-g27r5swe.web.app

(expires Tue, 31 Jan 2023 16:23:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@parlough parlough merged commit c9c64b6 into main Jan 24, 2023
@parlough parlough deleted the 2.19 branch June 9, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants