Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056

Merged
merged 40 commits into from
Jun 13, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented May 31, 2024

This commit updates Deno to use reqwest at 0.12.4
and rustls at 0.22. Other related crates were updated
as well to match versions accepted by reqwest and rustls.

Note: we are not using the latest available rustls yet,
but this upgrade was non-trivial already, so a bump to
0.23 for rustls will be done in a separate commit.

Closes #23370

Cargo.lock Outdated Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
ext/fetch/Cargo.toml Outdated Show resolved Hide resolved
ext/tls/lib.rs Outdated Show resolved Hide resolved
ext/tls/lib.rs Outdated Show resolved Hide resolved
ext/tls/tls_key.rs Outdated Show resolved Hide resolved
ext/tls/tls_key.rs Outdated Show resolved Hide resolved
tests/wpt/suite Outdated Show resolved Hide resolved
ext/tls/Cargo.toml Outdated Show resolved Hide resolved
ry added a commit that referenced this pull request Jun 5, 2024
To avoid duplicate winreg crate in #24056
bartlomieju added a commit that referenced this pull request Jun 5, 2024
To avoid duplicate winreg crate in #24056

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
@lucacasonato
Copy link
Member

lucacasonato commented Jun 6, 2024

Failing test is due to this change in hyper: seanmonstar/reqwest#2207

My two cents: seanmonstar/reqwest#2240 (comment)

If we land this as is, POST and PUT requests to some HTTP servers, including anything behind Google Load Balancer, probably break. As such I think we're blocked here until this is fixed in reqwest.

EDIT: My bad, I misinterpreted the issue - we're now adding content-length: 0 to PATCH requests that previously had no content-length. It's less bad, but probably should still be reverted.

EDIT2: It was already reverted in hyper 1.3.1, so upgrading to that will fix this. Sorry for the noise.

@bartlomieju bartlomieju changed the title chore: upgrade to reqwest 0.12.4 chore: upgrade to reqwest 0.12.4 and rustls 0.22 Jun 12, 2024
ext/tls/testdata/README Outdated Show resolved Hide resolved
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ry and others added 3 commits June 13, 2024 09:49
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
@bartlomieju bartlomieju merged commit fb31eaa into denoland:main Jun 13, 2024
17 checks passed
@bartlomieju bartlomieju deleted the migrate_reqwest branch June 13, 2024 20:41
bartlomieju added a commit that referenced this pull request Jun 18, 2024
This commit updates Deno to use `reqwest` at 0.12.4
and `rustls` at 0.22. Other related crates were updated
as well to match versions accepted by `reqwest` and `rustls`.

Note: we are not using the latest available `rustls` yet,
but this upgrade was non-trivial already, so a bump to
0.23 for `rustls` will be done in a separate commit.

Closes #23370

---------

Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jun 19, 2024
bartlomieju added a commit that referenced this pull request Jun 19, 2024
…24262)

This reverts commit fb31eaa.

Reverting because users reported spurious errors when downloading
dependencies - #24260.

Closes #24260
bartlomieju added a commit that referenced this pull request Jun 19, 2024
…24262)

This reverts commit fb31eaa.

Reverting because users reported spurious errors when downloading
dependencies - #24260.

Closes #24260
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 1, 2024
bartlomieju added a commit that referenced this pull request Jul 2, 2024
Reland of #24056 that doesn't
suffer from the problem that was discovered in
#24261.

It uses upgraded `hyper` and `hyper-util` that fixed the previous
problem in hyperium/hyper#3691.
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
)" (denoland#24262)

This reverts commit fb31eaa.

Reverting because users reported spurious errors when downloading
dependencies - denoland#24260.

Closes denoland#24260
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
Reland of denoland#24056 that doesn't
suffer from the problem that was discovered in
denoland#24261.

It uses upgraded `hyper` and `hyper-util` that fixed the previous
problem in hyperium/hyper#3691.
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
This commit updates Deno to use `reqwest` at 0.12.4
and `rustls` at 0.22. Other related crates were updated
as well to match versions accepted by `reqwest` and `rustls`.

Note: we are not using the latest available `rustls` yet,
but this upgrade was non-trivial already, so a bump to
0.23 for `rustls` will be done in a separate commit.

Closes denoland#23370

---------

Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
)" (denoland#24262)

This reverts commit fb31eaa.

Reverting because users reported spurious errors when downloading
dependencies - denoland#24260.

Closes denoland#24260
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
Reland of denoland#24056 that doesn't
suffer from the problem that was discovered in
denoland#24261.

It uses upgraded `hyper` and `hyper-util` that fixed the previous
problem in hyperium/hyper#3691.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Reqwest 0.12
5 participants