-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sbmsr/fix 21896 validate port on serve #24398
Closed
sbmsr
wants to merge
54
commits into
denoland:main
from
sbmsr:sbmsr/fix-21896-validate-port-on-serve
Closed
sbmsr/fix 21896 validate port on serve #24398
sbmsr
wants to merge
54
commits into
denoland:main
from
sbmsr:sbmsr/fix-21896-validate-port-on-serve
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" (denoland#24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - denoland#24260. Closes denoland#24260
This is the release commit being forwarded back to main for 1.44.4 Co-authored-by: bartlomieju <bartlomieju@users.noreply.github.com>
- add fallback impls of external string apis which always copy. after upstream changes to rusty_v8 we can support non-copying api as well. - `napi_get_buffer_data` needs to work on all TypedArray instances. - Fixes: denoland#24209 - `target_defaults.default_configuration` is used by some modules to find the corresponding node file from node-gyp - `node_api_get_module_filename` expects the filename to be a `file:` url.
…denoland#24319) Towards denoland#24236 --------- Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com> Co-authored-by: Satya Rohith <me@satyarohith.com>
Changes in this PR: - Added new fixed size hash algorithms (blake2b512, blake2s256, sha512-224, sha512-256, sha3-224, sha3-256, sha3-384, sha3-512, sm3) - Added variable size hash algorithms (the concept), with the algorithms shake128 and shake256 - Use cppgc instead of resources for the hasher - Enable Node's crypto.Hash tests and fix found bugs
This field is deprecated but still used by the ecosystem, so let's just support it.
No fixes in this to my knowledge. Just an upgrade. The functionality here will be used in a different PR.
Benchmark code from denoland#24341. ```shellsession $ deno run --allow-hrtime bench.mjs 6479.111583 $ target/release/deno run --allow-hrtime bench.mjs 962.753875 $ node bench.mjs 855.174875 ```
This commit adds discovery of `.npmrc` files in user's homedir. This is not a perfect fix as it doesn't merge multiple `.npmrc` files together as per denoland#23954 but allows to fallback if no `.npmrc` file is discovered in the project root.
…and#24366) As suggested in denoland#24355 (comment). I wasn't able to hide the mutex stuff as much as I'd like (ended up just adding an escape hatch `inner()` method that locks the inner mutex), because you can't return references to the inner fields through a mutex. This is mostly motivated by the frozen lockfile changes
Closes denoland#22947 This option is no longer needed as fast calls are now allowed to re-enter the isolate
The build broke in denoland#24365.
…d#24377) As per nodejs/node#46043, this adds Symbol.toStringTag getter to KeyObject.
- Symbol.asyncDispose no longer needs to be polyfilled - assorted updates for cppgc api changes
Atomically write `deno compile` output file so we won't get a partially written ELF/PE file, and prevents corrupting running processes.
Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/node/polyfills/_http_common.ts
(fix(ext/node): use primordials inext/node/polyfills/_http_common.ts
#24281)ext/node/polyfills/_process/
(fix(ext/node): use primordials inext/node/polyfills/_process/
#24282)ext/node/polyfills/_brotli.js
(fix(ext/node): use primordials inext/node/polyfills/_brotli.js
#24235)brotli::ffi
(refactor(ext): remove use ofbrotli::ffi
#24214)ext/node/polyfills/string_decoder.ts
(fix(ext/node): use primordials inext/node/polyfills/string_decoder.ts
#24296)import.meta.dirname
expected output (docs(cli): remove trailing slash fromimport.meta.dirname
expected output #24295)#[cppgc] &mut T
usage (Revert#[cppgc] &mut T
usage #24304)ext/node/polyfills/testing.ts
(fix(ext/node): use primordials inext/node/polyfills/testing.ts
#24310)ext/node/polyfills/timers.ts
(fix(ext/node): use primordials inext/node/polyfills/timers.ts
#24311)ext/node/polyfills/_fs/_fs_cp.js
(fix(ext/node): use primordials inext/node/polyfills/_fs/_fs_cp.js
#24320)ext/node/polyfills/_fs/_fs_dir.ts
(fix(ext/node): use primordials inext/node/polyfills/_fs/_fs_dir.ts
#24319)Buffer.from(buffer)
(perf(ext/node): improveBuffer.from(buffer)
#24352)Array.prototype
tampering (fix(ext/node): make next tick queue resilient toArray.prototype
tampering #24361)deno_lockfile::Lockfile
(refactor(cli): Create wrapper arounddeno_lockfile::Lockfile
#24366)Blob.prototype.bytes()
(feat(ext/web): addBlob.prototype.bytes()
#24148)