-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic creation of users with ldap authentication #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.0.2 - Patches
… when configuring an ldap authentication
…ion_type Variable LDAP_AUTHENTICATION_TYPE in .env.model
…ap authentication. Added configuration variable LDAP_USER_PROVISIONING
…ot unicity of the email which does not work)
…ser rather than a fixed one
…P_USER_ATTRIBUTE_MAIL to retrieve user name and email from ldap
…RIS_AUTHENTICATION_CREATE_USER_IF_NOT_EXIST which already existed
…TIFIER to search for users information in the ldap
…CATION_CREATE_USER_IF_NOT_EXIST
whikernel
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #203, this pull-request adds the creation of users present in ldap at their first login.
The behaviour is activated by setting variable IRIS_AUTHENTICATION_CREATE_USER_IF_NOT_EXIST to True.
The following variables were added:
A fake local password is chosen randomly (same way as the administrator password is set). Ideally, it would be better if the database accepted the creation of users without any local password. This could be a further improvement of the code.
Note that the email unicity requirement may prove to be a problem at some point (if two users happen to have the same email in ldap, this may be possible in theory)
Note that in case of NTLM, the domain name is stripped to get the value of the sAMAccountName.