refactor: improve TransactionWaiter
#1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
+ Coverage 65.33% 65.97% +0.64%
==========================================
Files 228 228
Lines 19620 19835 +215
==========================================
+ Hits 12818 13087 +269
+ Misses 6802 6748 -54 ☔ View full report in Codecov by Sentry. |
kariy
force-pushed
the
tx-wait-improv
branch
from
0968a05
to
c5b6674
Compare
tarrencev
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
TransactionWaitertype by usinggetTransactionStatusendpoint when querying for the tx status before requesting for its receipt. Which means the waiter should now be able to handle transaction withREJECTED/RECEIVEDstatus.