-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retry on TransactionHashNotFound
error
#1435
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
+ Coverage 67.55% 67.62% +0.06%
==========================================
Files 218 218
Lines 21011 21055 +44
==========================================
+ Hits 14195 14238 +43
- Misses 6816 6817 +1 ☔ View full report in Codecov by Sentry. |
I was under the assumption that the receipt should be available if the status is already But, anyway, I think this change is good. |
I think the issue is when you're using a rpc provider like alchemy, where they are running multiple pathfinder instances, and your requests are load balanced. basically the execute will happen on a different rpc node from the get txn and there can be a delay between the first node executing and the second node receiving the txn |
ah make sense |
oh i thought it was a bug in RPC, but this explanation makes more sense |
related: #1340
we are only calling
get_transaction_receipt
after we getAccepted_on_L2/Accepted_on_L1
fromget_transaction_status
, still rpc returnsTransactionHashNotFound
in which case we simply retry after sometime.