Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry on TransactionHashNotFound error #1435

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

lambda-0x
Copy link
Collaborator

related: #1340

we are only calling get_transaction_receipt after we get Accepted_on_L2/Accepted_on_L1 from get_transaction_status, still rpc returns TransactionHashNotFound in which case we simply retry after sometime.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (942d895) 67.55% compared to head (a3535d6) 67.62%.
Report is 3 commits behind head on main.

Files Patch % Lines
crates/dojo-world/src/utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
+ Coverage   67.55%   67.62%   +0.06%     
==========================================
  Files         218      218              
  Lines       21011    21055      +44     
==========================================
+ Hits        14195    14238      +43     
- Misses       6816     6817       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm requested a review from kariy January 13, 2024 20:11
@kariy
Copy link
Member

kariy commented Jan 14, 2024

I was under the assumption that the receipt should be available if the status is already ACCEPTED_ON_* (which is the current behaviour of katana). Does that mean the tx status doesn't exactly enforce the availability of the receipt?

But, anyway, I think this change is good.

@kariy kariy merged commit 7a7daf8 into dojoengine:main Jan 14, 2024
10 checks passed
@tarrencev
Copy link
Contributor

I think the issue is when you're using a rpc provider like alchemy, where they are running multiple pathfinder instances, and your requests are load balanced. basically the execute will happen on a different rpc node from the get txn and there can be a delay between the first node executing and the second node receiving the txn

@kariy
Copy link
Member

kariy commented Jan 14, 2024

I think the issue is when you're using a rpc provider like alchemy, where they are running multiple pathfinder instances, and your requests are load balanced. basically the execute will happen on a different rpc node from the get txn and there can be a delay between the first node executing and the second node receiving the txn

ah make sense

@lambda-0x
Copy link
Collaborator Author

I think the issue is when you're using a rpc provider like alchemy, where they are running multiple pathfinder instances, and your requests are load balanced. basically the execute will happen on a different rpc node from the get txn and there can be a delay between the first node executing and the second node receiving the txn

oh i thought it was a bug in RPC, but this explanation makes more sense

@lambda-0x lambda-0x deleted the fix-waiter branch January 14, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants