-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(katana): improve error handling #1415
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,26 @@ | ||
use blockifier::execution::errors::EntryPointExecutionError; | ||
use blockifier::state::errors::StateError; | ||
use blockifier::transaction::errors::TransactionExecutionError; | ||
use katana_primitives::block::BlockIdOrTag; | ||
use katana_primitives::contract::ContractAddress; | ||
use katana_primitives::event::ContinuationTokenError; | ||
use katana_primitives::transaction::TxHash; | ||
use starknet_api::StarknetApiError; | ||
use katana_provider::error::ProviderError; | ||
|
||
#[derive(Debug, thiserror::Error)] | ||
pub enum SequencerError { | ||
#[error("Block {0:?} not found.")] | ||
BlockNotFound(BlockIdOrTag), | ||
#[error("Contract address {0:?} not found.")] | ||
#[error("Contract address {0} not found.")] | ||
ContractNotFound(ContractAddress), | ||
#[error("State update for block {0:?} not found.")] | ||
StateUpdateNotFound(BlockIdOrTag), | ||
#[error("State for block {0:?} not found.")] | ||
StateNotFound(BlockIdOrTag), | ||
#[error("Transaction with {0} hash not found.")] | ||
TxnNotFound(TxHash), | ||
#[error(transparent)] | ||
State(#[from] StateError), | ||
#[error(transparent)] | ||
TransactionExecution(#[from] TransactionExecutionError), | ||
#[error("Error converting {from} into {to}: {message}")] | ||
ConversionError { from: String, to: String, message: String }, | ||
#[error(transparent)] | ||
StarknetApi(#[from] StarknetApiError), | ||
#[error(transparent)] | ||
EntryPointExecution(#[from] EntryPointExecutionError), | ||
#[error("Wait for pending transactions.")] | ||
PendingTransactions, | ||
#[error("Unsupported Transaction")] | ||
UnsupportedTransaction, | ||
#[error(transparent)] | ||
ContinuationToken(#[from] ContinuationTokenError), | ||
#[error("Error serializing state.")] | ||
StateSerialization, | ||
#[error("Required data unavailable")] | ||
DataUnavailable, | ||
#[error("Failed to decode state")] | ||
FailedToDecodeStateDump, | ||
#[error(transparent)] | ||
Other(#[from] anyhow::Error), | ||
Provider(#[from] ProviderError), | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would just add
expect("ForkedProvider backend thread couldn't be started")
or perhaps in next PRs with checking whichunwrap
are controlled and which are not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I could put that in, but I want to refactor the caller function to also propagate the error.
Would do that in the next PR.