refactor(katana): improve error handling #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/katana #1415 +/- ##
=============================================
Coverage ? 67.95%
=============================================
Files ? 220
Lines ? 21403
Branches ? 0
=============================================
Hits ? 14544
Misses ? 6859
Partials ? 0 ☔ View full report in Codecov by Sentry. |
glihm
approved these changes
Jan 11, 2024
| @@ -95,7 +95,7 @@ impl Backend { | |||
| ); | |||
|
|
|||
| let blockchain = Blockchain::new_from_forked( | |||
| ForkedProvider::new(provider, forked_block_num.into()), | |||
| ForkedProvider::new(provider, forked_block_num.into()).unwrap(), | |||
There was a problem hiding this comment.
Would just add expect("ForkedProvider backend thread couldn't be started") or perhaps in next PRs with checking which unwrap are controlled and which are not?
There was a problem hiding this comment.
Good idea. I could put that in, but I want to refactor the caller function to also propagate the error.
Would do that in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial error handling improvement. The idea is to not rely on
anyhowon lib level andkatana-providersreplacinganyhow.SequencerErrorenum.UnexpectedErrorvariant ofStarknetApiErrorinto a struct with areasonfield.