Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(katana): db storage intergration #1440

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 15, 2024

Depends on #1436

This PR adds persistent db as one of the available options for katana storage implementations, along with in-memory and forked db.

  • Adds --db-dir <PATH> CLI arg. for specifying where the DB directory will be located.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on typo and comment.
This PR is the achievement of a great work on persistence @kariy, well done! 🔥

crates/katana/core/src/backend/storage.rs Outdated Show resolved Hide resolved
crates/katana/storage/db/src/utils.rs Outdated Show resolved Hide resolved
@kariy kariy deleted the branch dojoengine:dev/katana January 16, 2024 06:52
@kariy kariy closed this Jan 16, 2024
@kariy kariy reopened this Jan 16, 2024
@kariy kariy changed the base branch from 1347-historical-block-context to dev/katana January 16, 2024 07:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev/katana@5031257). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/katana    #1440   +/-   ##
=============================================
  Coverage              ?   68.50%           
=============================================
  Files                 ?      220           
  Lines                 ?    21690           
  Branches              ?        0           
=============================================
  Hits                  ?    14858           
  Misses                ?     6832           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 58a122d into dojoengine:dev/katana Jan 16, 2024
10 checks passed
@kariy kariy deleted the db-intergrate branch January 16, 2024 15:31
@kariy kariy mentioned this pull request Jan 16, 2024
kariy added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants