Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Katana dev branch #1444

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Merge Katana dev branch #1444

merged 5 commits into from
Jan 17, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 16, 2024

PRs included:

#1440
#1436
#1351
#1403
#1415

Issues resolved:

#1370
#1347
#1356

@kariy kariy requested a review from glihm January 16, 2024 15:44
@codecov-commenter
Copy link

Codecov Report

Attention: 230 lines in your changes are missing coverage. Please review.

Comparison is base (87599f9) 67.62% compared to head (58a122d) 68.50%.

Files Patch % Lines
crates/katana/rpc/src/starknet.rs 26.19% 93 Missing ⚠️
crates/katana/storage/provider/src/lib.rs 70.96% 18 Missing ⚠️
crates/katana/rpc/src/api/starknet.rs 36.00% 16 Missing ⚠️
crates/katana/core/src/backend/mod.rs 85.85% 14 Missing ⚠️
crates/katana/core/src/service/block_producer.rs 76.27% 14 Missing ⚠️
.../katana/storage/provider/src/providers/fork/mod.rs 82.60% 12 Missing ⚠️
crates/katana/primitives/src/chain.rs 91.83% 8 Missing ⚠️
...na/storage/provider/src/providers/in_memory/mod.rs 88.88% 7 Missing ⚠️
crates/katana/rpc/rpc-types/src/block.rs 25.00% 6 Missing ⚠️
.../katana/storage/provider/src/providers/db/state.rs 86.04% 6 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
+ Coverage   67.62%   68.50%   +0.87%     
==========================================
  Files         218      220       +2     
  Lines       21060    21690     +630     
==========================================
+ Hits        14242    14858     +616     
- Misses       6818     6832      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great man, some minor comments for now.


pub const DEFAULT_INVOKE_MAX_STEPS: u32 = 1_000_000;
pub const DEFAULT_VALIDATE_MAX_STEPS: u32 = 1_000_000;

pub const MAX_RECURSION_DEPTH: usize = 1000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub const MAX_RECURSION_DEPTH: usize = 1000;
pub const DEFAULT_MAX_RECURSION_DEPTH: usize = 1000;

}

Err(err) => {
trace!(target: "node", "failed to mine block: {err}");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
trace!(target: "node", "failed to mine block: {err}");
error!(target: "node", "failed to mine block: {err}");

@kariy kariy marked this pull request as ready for review January 17, 2024 14:35
@kariy kariy merged commit de5bbe8 into main Jan 17, 2024
10 checks passed
@kariy kariy deleted the dev/katana branch January 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants