Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] Use 8.x Microsoft.Extensions.* packages #34769

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Sep 26, 2024

Description
For 9 EF still targets net8.0 to help with adoption for users staying on the LTS SDK, but we depend on 9.0.x versions of Microsoft.Extensions.* packages.

Customer impact
When deploying an app targeting net8.0, the Microsoft.Extensions.* packages will be deployed too instead of using the shared framework.

How found
Reported on 9 RC1 by partner team (Aspire - dotnet/aspire#5932 (review)).

Regression
No

Testing
Tested manually

Risk
Low.

@AndriySvyryd AndriySvyryd changed the title [release/9.0] Use 8.x Extension packages [release/9.0] Use 8.x Microsoft.Extensions.* packages Oct 2, 2024
@AndriySvyryd AndriySvyryd requested a review from a team October 2, 2024 18:38
@sebastienros
Copy link
Member

What is the reason to run benchmarks and tests with 9.0 dependencies?
Are the tests run in both 8 and 9? Could only find DefaultNetCoreTargetFramework in a random test csproj.

@AndriySvyryd
Copy link
Member Author

What is the reason to run benchmarks and tests with 9.0 dependencies?

That's still the mainline scenario for EF Core 9

Are the tests run in both 8 and 9? Could only find DefaultNetCoreTargetFramework in a random test csproj.

No, I tested it manually for net8.0 with 8.0.x dependencies. Multi-targeting all the tests is non-trivial and something that would only apply to this release.

@artl93
Copy link
Member

artl93 commented Oct 2, 2024

@AndriySvyryd, @ericstj and I were chatting - what's the servicing story here when .NET 8 ship an MSRC fix and entity framework in 9.0 needs to sim-ship that fix?

@AndriySvyryd
Copy link
Member Author

@artl93 You mean that one of the 8.0.x dependencies needs to be updated at the same time it's shipped?
@mmitche can correct me here, but we already consume the dotnet8 feed when building EF Core 9, so it should be just a matter of scheduling the builds in the correct order.

@ericstj
Copy link
Member

ericstj commented Oct 3, 2024

i'm not sure what the process is for entity framework, but for the rest of the product we don't flow changes across bands. Doing so would delay builds in later versions and reset them when earlier versions rebuild. We also try to avoid these dependencies for source build, because they require explicit reference packages. Again I'm not sure if that would apply to entity framework or not.

Boils down to what sort of package is entity framework. Is it part of .net versioning and servicing with .net or is it something on top?

@AndriySvyryd
Copy link
Member Author

Boils down to what sort of package is entity framework. Is it part of .net versioning and servicing with .net or is it something on top?

EF Core is shipped and serviced following the same schedule as .NET, but it's not part of source build, SDK or VS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants