Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cycle caused by calculation of ObsoleteState/ExperimentalState. #70171

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Avoid cycle caused by calculation of ObsoleteState/ExperimentalState. #70171

merged 3 commits into from
Oct 11, 2023

Conversation

AlekseyTs
Copy link
Contributor

Fixes #70007.

@AlekseyTs AlekseyTs requested a review from a team as a code owner September 28, 2023 17:24
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 28, 2023
@jcouv jcouv self-assigned this Sep 28, 2023
jcouv
jcouv approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv
Copy link
Member

jcouv commented Sep 28, 2023 •
edited
Loading

Do you want to target 17.8?

@AlekseyTs
Copy link
Contributor Author

Do you want to target 17.8?

I was going to suggest that. @jaredpar, What do you think?

@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review

@AlekseyTs AlekseyTs changed the base branch from main to release/dev17.8 September 28, 2023 20:07
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review of a small bug fix targeting17.8

@AlekseyTs AlekseyTs added this to the 17.8 milestone Sep 28, 2023
@AlekseyTs
Copy link
Contributor Author

@dotnet/roslyn-compiler For the second review of a small bug fix targeting17.8

@AlekseyTs AlekseyTs enabled auto-merge (squash) September 30, 2023 00:06
@AlekseyTs AlekseyTs added the Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner. label Oct 4, 2023
@AlekseyTs
Copy link
Contributor Author

Please squash while merging.

@jaredpar jaredpar merged commit d49b29e into dotnet:release/dev17.8 Oct 11, 2023
25 checks passed
@allisonchou allisonchou mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@chsienki chsienki chsienki approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Tenet-Reliability Customer telemetry indicates that the product is failing in a crash/hang/dataloss manner. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.

StackoverflowException when compiling VB.NET project
4 participants
@AlekseyTs @jcouv @chsienki @jaredpar