Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cycle caused by calculation of ObsoleteState/ExperimentalState. #70171

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Avoid cycle caused by calculation of ObsoleteState/ExperimentalState. #70171

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f74a1
Avoid cycle caused by calculation of ObsoleteState/ExperimentalState.
AlekseyTs Sep 28, 2023
46123d5
Add C# test
AlekseyTs Sep 28, 2023
de9ae9b
More tests
AlekseyTs Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/Compilers/CSharp/Test/Semantic/Semantics/BindingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3680,5 +3680,27 @@ void N()
var typeInfo = model.GetTypeInfo(lambda.Body);
Assert.Equal("System.Int32", typeInfo.Type.ToTestDisplayString());
}

[Fact]
[WorkItem("https://github.com/dotnet/roslyn/issues/70007")]
public void CycleThroughAttribute()
{
var compilation = CreateCompilation(@"
using System.Reflection;

[assembly: AssemblyVersion(MainVersion.CurrentVersion)]

public class MainVersion
{
public const string Hauptversion = ""8"";
public const string Nebenversion = ""2"";
public const string Build = ""0"";
public const string Revision = ""1"";

public const string CurrentVersion = Hauptversion + ""."" + Nebenversion + ""."" + Build + ""."" + Revision;
}
");
CompileAndVerify(compilation).VerifyDiagnostics();
}
}
}
2 changes: 1 addition & 1 deletion src/Compilers/VisualBasic/Portable/Binding/Binder_Initializers.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
End If

Dim boundInitValueHasErrorsOrConstTypeIsWrong As Boolean =
initValueDiagnostics.HasAnyErrors OrElse fieldSymbol.HasDeclaredType AndAlso Not targetType.IsValidTypeForConstField()
initValueDiagnostics.HasAnyResolvedErrors OrElse fieldSymbol.HasDeclaredType AndAlso Not targetType.IsValidTypeForConstField()

' NOTE: we'll only report ERR_RequiredConstConversion2 ("Conversion from '...' to '.' cannot occur in
' NOTE: a constant expression") and ERR_RequiredConstExpr ("Constant expression is required") in case
Expand Down
24 changes: 24 additions & 0 deletions src/Compilers/VisualBasic/Test/Semantic/Binding/Binder_Expressions_Tests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3446,5 +3446,29 @@ End Class </file>

CompileAndVerify(compilation, expectedOutput:="42")
End Sub

<WorkItem("https://github.com/dotnet/roslyn/issues/70007")>
<Fact()>
Public Sub CycleThroughAttribute()
Dim compilation = CreateCompilation(
<compilation>
<file name="a.vb"><![CDATA[
Imports System.Reflection

<Assembly: AssemblyVersion(MainVersion.CurrentVersion)>

Public Class MainVersion
Public Const Hauptversion As String = "8"
Public Const Nebenversion As String = "2"
Public Const Build As String = "0"
Public Const Revision As String = "1"

Public Const CurrentVersion As String = Hauptversion & "." & Nebenversion & "." & Build & "." & Revision
End Class
]]></file>
</compilation>)

CompileAndVerify(compilation).VerifyDiagnostics()
End Sub
End Class
End Namespace
Loading