[40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail only if tcrypt insmod failed.
When dropped to emergency shell, for example, use rd.break=pre-pivot,
the PS1 won't correctly show current directory we're in:
pre-pivot:/# cd /sysroot/
pre-pivot:/#
(still shows "/")
Let's take a look at PS1 variable:
(I'm adding prefix/suffix 'x' to make it clear):
pre-pivot:/# echo x${PS1}x
xpre-pivot:/# x
(PS1 isn't dynamic)
Regarding the current dracut code, it should be:
pre-pivot:/# cd /sysroot/etc
pre-pivot:/sysroot/etc#
With this patch:
pre-pivot:/# echo x${PS1}x
xpre-pivot:${PWD}# x
(Now PS1 is dynamic, it will show the directory correctly)
I tested for both normal boot and kdump boot.
Signed-off-by: WANG Chao <chaowang@redhat.com>
zfcp_cfdc will go away in the future tt
… bringing up an interface
johannbg
added
modules
haraldh
added a commit
that referenced
this pull request
Feb 25, 2021
Before: ``` Benchmark #1: ./skipcpio/skipcpio test-5.10.15-200.fc33.x86_64.img >/dev/null Time (mean ± σ): 125.5 ms ± 0.9 ms [User: 97.4 ms, System: 27.9 ms] Range (min … max): 124.8 ms … 129.4 ms 23 runs ``` After: ``` Benchmark #1: ./skipcpio/skipcpio test-5.10.15-200.fc33.x86_64.img >/dev/null Time (mean ± σ): 12.2 ms ± 0.3 ms [User: 2.7 ms, System: 9.5 ms] Range (min … max): 11.7 ms … 13.6 ms 212 runs ``` Besides the speedup, skipcpio now parses the cpio header and is not falsely ending when the early cpio payload contains `TRAILER!!!`. Fixes: #1123
ddiss
referenced
this pull request
in ddiss/dracut
Mar 10, 2021
Before: ``` Benchmark #1: ./skipcpio/skipcpio test-5.10.15-200.fc33.x86_64.img >/dev/null Time (mean ± σ): 125.5 ms ± 0.9 ms [User: 97.4 ms, System: 27.9 ms] Range (min … max): 124.8 ms … 129.4 ms 23 runs ``` After: ``` Benchmark #1: ./skipcpio/skipcpio test-5.10.15-200.fc33.x86_64.img >/dev/null Time (mean ± σ): 12.2 ms ± 0.3 ms [User: 2.7 ms, System: 9.5 ms] Range (min … max): 11.7 ms … 13.6 ms 212 runs ``` Besides the speedup, skipcpio now parses the cpio header and is not falsely ending when the early cpio payload contains `TRAILER!!!`. Fixes: dracutdevs#1123 (cherry picked from commit 6303349)
pfliu
pushed a commit
to pfliu/dracut
that referenced
this pull request
Jul 9, 2021
When running kdump on PowerPC, the following bug is hit: [ 0.391629] Freeing unused kernel memory: 5568K [ 0.391634] This architecture does not have kernel memory protection. /bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory [ 0.392214] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00 [ 0.392214] [ 0.392223] CPU: 6 PID: 1 Comm: init Not tainted 4.18.0-319.el8.ppc64le dracutdevs#1 [ 0.392228] Call Trace: [ 0.392234] [c00000000c703c10] [c000000008ecb94c] dump_stack+0xb0/0xf4 (unreliable) [ 0.392243] [c00000000c703c50] [c000000008167324] panic+0x148/0x3c4 [ 0.392249] [c00000000c703cf0] [c000000008170474] do_exit+0xcd4/0xd40 [ 0.392255] [c00000000c703dc0] [c0000000081705b0] do_group_exit+0x60/0x110 [ 0.392261] [c00000000c703e00] [c000000008170684] sys_exit_group+0x24/0x30 [ 0.392268] [c00000000c703e20] [c00000000800b408] system_call+0x5c/0x70 This is due to the non-conventional library path: ldd /bin/bash linux-vdso64.so.1 (0x00007fffbdc90000) libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fffbda80000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fffbda50000) libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffbd830000) ^^^ /lib64/ld64.so.2 (0x00007fffbdcb0000) During the process of building kdumpimg, all of dynamic library info have been cached in ld.so.cache. Hence this bug can be simplely resolved by keeping ld cache under $initdir/etc Signed-off-by: Pingfan Liu <piliu@redhat.com>
3 tasks
pfliu
pushed a commit
to pfliu/dracut
that referenced
this pull request
Jul 20, 2021
When running kdump on PowerPC, the following bug is hit: [ 0.391629] Freeing unused kernel memory: 5568K [ 0.391634] This architecture does not have kernel memory protection. /bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory [ 0.392214] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00 [ 0.392214] [ 0.392223] CPU: 6 PID: 1 Comm: init Not tainted 4.18.0-319.el8.ppc64le dracutdevs#1 [ 0.392228] Call Trace: [ 0.392234] [c00000000c703c10] [c000000008ecb94c] dump_stack+0xb0/0xf4 (unreliable) [ 0.392243] [c00000000c703c50] [c000000008167324] panic+0x148/0x3c4 [ 0.392249] [c00000000c703cf0] [c000000008170474] do_exit+0xcd4/0xd40 [ 0.392255] [c00000000c703dc0] [c0000000081705b0] do_group_exit+0x60/0x110 [ 0.392261] [c00000000c703e00] [c000000008170684] sys_exit_group+0x24/0x30 [ 0.392268] [c00000000c703e20] [c00000000800b408] system_call+0x5c/0x70 This is due to the non-conventional library path: ldd /bin/bash linux-vdso64.so.1 (0x00007fffbdc90000) libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fffbda80000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fffbda50000) libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffbd830000) ^^^ /lib64/ld64.so.2 (0x00007fffbdcb0000) ldd finds the path by libc.so.6 -> /usr/lib64/libc.so.6 -> /usr/lib64/glibc-hwcaps/power9/libc-2.28.so and cache the result. So when dracut_install, it only saw '/usr/lib64/glibc-hwcaps/power9/libc-2.28.so' and blind to '/usr/lib64/libc.so.6' In the final kdumpimg, the symlink /usr/lib64/libc.so.6 is not created, hence ld.so can not find the /usr/lib64/glibc-hwcaps/power9/libc-2.28.so On the other hand, during the process of building kdumpimg, all of dynamic library info have been cached in ld.so.cache. Hence this bug can be simplely resolved by keeping ld cache under $initdir/etc. Signed-off-by: Pingfan Liu <piliu@redhat.com> --- v3 -> v4: use inst() instead of copy v2 -> v3: fix format by shfmt -s -w modules.d/99squash/module-setup.sh v1 -> v2: cp -r /etc/ld.so* instead of move, since after switch-root, initdir can not be seen any longer
johannbg
pushed a commit
that referenced
this pull request
Jul 20, 2021
When running kdump on PowerPC, the following bug is hit: [ 0.391629] Freeing unused kernel memory: 5568K [ 0.391634] This architecture does not have kernel memory protection. /bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory [ 0.392214] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00 [ 0.392214] [ 0.392223] CPU: 6 PID: 1 Comm: init Not tainted 4.18.0-319.el8.ppc64le #1 [ 0.392228] Call Trace: [ 0.392234] [c00000000c703c10] [c000000008ecb94c] dump_stack+0xb0/0xf4 (unreliable) [ 0.392243] [c00000000c703c50] [c000000008167324] panic+0x148/0x3c4 [ 0.392249] [c00000000c703cf0] [c000000008170474] do_exit+0xcd4/0xd40 [ 0.392255] [c00000000c703dc0] [c0000000081705b0] do_group_exit+0x60/0x110 [ 0.392261] [c00000000c703e00] [c000000008170684] sys_exit_group+0x24/0x30 [ 0.392268] [c00000000c703e20] [c00000000800b408] system_call+0x5c/0x70 This is due to the non-conventional library path: ldd /bin/bash linux-vdso64.so.1 (0x00007fffbdc90000) libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fffbda80000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fffbda50000) libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffbd830000) ^^^ /lib64/ld64.so.2 (0x00007fffbdcb0000) ldd finds the path by libc.so.6 -> /usr/lib64/libc.so.6 -> /usr/lib64/glibc-hwcaps/power9/libc-2.28.so and cache the result. So when dracut_install, it only saw '/usr/lib64/glibc-hwcaps/power9/libc-2.28.so' and blind to '/usr/lib64/libc.so.6' In the final kdumpimg, the symlink /usr/lib64/libc.so.6 is not created, hence ld.so can not find the /usr/lib64/glibc-hwcaps/power9/libc-2.28.so On the other hand, during the process of building kdumpimg, all of dynamic library info have been cached in ld.so.cache. Hence this bug can be simplely resolved by keeping ld cache under $initdir/etc. Signed-off-by: Pingfan Liu <piliu@redhat.com> --- v3 -> v4: use inst() instead of copy v2 -> v3: fix format by shfmt -s -w modules.d/99squash/module-setup.sh v1 -> v2: cp -r /etc/ld.so* instead of move, since after switch-root, initdir can not be seen any longer
ryncsn
pushed a commit
to ryncsn/dracut
that referenced
this pull request
Aug 10, 2021
When running kdump on PowerPC, the following bug is hit: [ 0.391629] Freeing unused kernel memory: 5568K [ 0.391634] This architecture does not have kernel memory protection. /bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory [ 0.392214] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00 [ 0.392214] [ 0.392223] CPU: 6 PID: 1 Comm: init Not tainted 4.18.0-319.el8.ppc64le dracutdevs#1 [ 0.392228] Call Trace: [ 0.392234] [c00000000c703c10] [c000000008ecb94c] dump_stack+0xb0/0xf4 (unreliable) [ 0.392243] [c00000000c703c50] [c000000008167324] panic+0x148/0x3c4 [ 0.392249] [c00000000c703cf0] [c000000008170474] do_exit+0xcd4/0xd40 [ 0.392255] [c00000000c703dc0] [c0000000081705b0] do_group_exit+0x60/0x110 [ 0.392261] [c00000000c703e00] [c000000008170684] sys_exit_group+0x24/0x30 [ 0.392268] [c00000000c703e20] [c00000000800b408] system_call+0x5c/0x70 This is due to the non-conventional library path: ldd /bin/bash linux-vdso64.so.1 (0x00007fffbdc90000) libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fffbda80000) libdl.so.2 => /lib64/libdl.so.2 (0x00007fffbda50000) libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffbd830000) ^^^ /lib64/ld64.so.2 (0x00007fffbdcb0000) ldd finds the path by libc.so.6 -> /usr/lib64/libc.so.6 -> /usr/lib64/glibc-hwcaps/power9/libc-2.28.so and cache the result. So when dracut_install, it only saw '/usr/lib64/glibc-hwcaps/power9/libc-2.28.so' and blind to '/usr/lib64/libc.so.6' In the final kdumpimg, the symlink /usr/lib64/libc.so.6 is not created, hence ld.so can not find the /usr/lib64/glibc-hwcaps/power9/libc-2.28.so On the other hand, during the process of building kdumpimg, all of dynamic library info have been cached in ld.so.cache. Hence this bug can be simplely resolved by keeping ld cache under $initdir/etc. Signed-off-by: Pingfan Liu <piliu@redhat.com> --- v3 -> v4: use inst() instead of copy v2 -> v3: fix format by shfmt -s -w modules.d/99squash/module-setup.sh v1 -> v2: cp -r /etc/ld.so* instead of move, since after switch-root, initdir can not be seen any longer (cherry picked from commit dc21638) Resolves: #1959336
pvalena
pushed a commit
to pvalena/dracut
that referenced
this pull request
Feb 15, 2022
CI configuration
runsisi
added a commit
to runsisi/dracut
that referenced
this pull request
Aug 6, 2022
in install_dependent_modules we use &path[kerneldirlen] as the key for inserting, let's do the same for checking. otherwise installing kernel module has circular dependency from a custom kernel module directory will cause infinite recursion and segfault. $ grep ipmi kbuilt/lib/modules/5.10.121/modules.dep kernel/drivers/char/ipmi/ipmi_msghandler.ko: kernel/drivers/char/ipmi/ipmi_devintf.ko: kernel/drivers/char/ipmi/ipmi_msghandler.ko $ grep ipmi kbuilt/lib/modules/5.10.121/modules.softdep softdep ipmi_msghandler post: ipmi_devintf $ ./dracut-install -D /tmp --kerneldir ~/working/kernel/linux-5.10.121/kbuilt/lib/modules/5.10.121 -m ipmi-devintf Segmentation fault (core dumped) (gdb) b install_dependent_modules Breakpoint 1 at 0x7db0: file src/install/dracut-install.c, line 1513. (gdb) bt #0 install_dependent_modules (modlist=0x0) at src/install/dracut-install.c:1513 dracutdevs#1 0x000055555555c027 in install_dependent_modules (modlist=modlist@entry=0x555555579e90) at src/install/dracut-install.c:1553 dracutdevs#2 0x000055555555bf1c in install_dependent_modules (modlist=0x5555555799d0) at src/install/dracut-install.c:1548 dracutdevs#3 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557a3f0) at src/install/dracut-install.c:1554 dracutdevs#4 0x000055555555bf1c in install_dependent_modules (modlist=0x555555579d60) at src/install/dracut-install.c:1548 dracutdevs#5 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557b170) at src/install/dracut-install.c:1554 dracutdevs#6 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557a0f0) at src/install/dracut-install.c:1548 dracutdevs#7 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555575320) at src/install/dracut-install.c:1554 dracutdevs#8 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557ab30) at src/install/dracut-install.c:1548 dracutdevs#9 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557dd60) at src/install/dracut-install.c:1554 dracutdevs#10 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557b640) at src/install/dracut-install.c:1548 dracutdevs#11 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557e0f0) at src/install/dracut-install.c:1554 dracutdevs#12 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557b9d0) at src/install/dracut-install.c:1548 dracutdevs#13 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555574340) at src/install/dracut-install.c:1554 dracutdevs#14 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557cf70) at src/install/dracut-install.c:1548 dracutdevs#15 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x5555555768d0) at src/install/dracut-install.c:1554 dracutdevs#16 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557d750) at src/install/dracut-install.c:1548 dracutdevs#17 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557e700) at src/install/dracut-install.c:1554 dracutdevs#18 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557de90) at src/install/dracut-install.c:1548 dracutdevs#19 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555581c90) at src/install/dracut-install.c:1554 dracutdevs#20 0x000055555555bf1c in install_dependent_modules (modlist=0x555555571e60) at src/install/dracut-install.c:1548 dracutdevs#21 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555556b620) at src/install/dracut-install.c:1554 dracutdevs#22 0x000055555555bf1c in install_dependent_modules (modlist=0x555555583000) at src/install/dracut-install.c:1548 dracutdevs#23 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555556b640) at src/install/dracut-install.c:1554 dracutdevs#24 0x000055555555bf1c in install_dependent_modules (modlist=0x555555571b40) at src/install/dracut-install.c:1548 dracutdevs#25 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555574100) at src/install/dracut-install.c:1554 dracutdevs#26 0x000055555555c4b0 in install_module (mod=mod@entry=0x555555573bc0) at src/install/dracut-install.c:1617 dracutdevs#27 0x000055555555c93d in install_modules (argc=argc@entry=1, argv=argv@entry=0x7fffffffd6e0) at src/install/dracut-install.c:1952 dracutdevs#28 0x000055555555862a in main (argc=<optimized out>, argv=0x7fffffffd6a8) at src/install/dracut-install.c:2090 Signed-off-by: runsisi <runsisi@hust.edu.cn>
johannbg
pushed a commit
that referenced
this pull request
Aug 15, 2022
in install_dependent_modules we use &path[kerneldirlen] as the key for inserting, let's do the same for checking. otherwise installing kernel module has circular dependency from a custom kernel module directory will cause infinite recursion and segfault. $ grep ipmi kbuilt/lib/modules/5.10.121/modules.dep kernel/drivers/char/ipmi/ipmi_msghandler.ko: kernel/drivers/char/ipmi/ipmi_devintf.ko: kernel/drivers/char/ipmi/ipmi_msghandler.ko $ grep ipmi kbuilt/lib/modules/5.10.121/modules.softdep softdep ipmi_msghandler post: ipmi_devintf $ ./dracut-install -D /tmp --kerneldir ~/working/kernel/linux-5.10.121/kbuilt/lib/modules/5.10.121 -m ipmi-devintf Segmentation fault (core dumped) (gdb) b install_dependent_modules Breakpoint 1 at 0x7db0: file src/install/dracut-install.c, line 1513. (gdb) bt #0 install_dependent_modules (modlist=0x0) at src/install/dracut-install.c:1513 #1 0x000055555555c027 in install_dependent_modules (modlist=modlist@entry=0x555555579e90) at src/install/dracut-install.c:1553 #2 0x000055555555bf1c in install_dependent_modules (modlist=0x5555555799d0) at src/install/dracut-install.c:1548 #3 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557a3f0) at src/install/dracut-install.c:1554 #4 0x000055555555bf1c in install_dependent_modules (modlist=0x555555579d60) at src/install/dracut-install.c:1548 #5 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557b170) at src/install/dracut-install.c:1554 #6 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557a0f0) at src/install/dracut-install.c:1548 #7 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555575320) at src/install/dracut-install.c:1554 #8 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557ab30) at src/install/dracut-install.c:1548 #9 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557dd60) at src/install/dracut-install.c:1554 #10 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557b640) at src/install/dracut-install.c:1548 #11 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557e0f0) at src/install/dracut-install.c:1554 #12 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557b9d0) at src/install/dracut-install.c:1548 #13 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555574340) at src/install/dracut-install.c:1554 #14 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557cf70) at src/install/dracut-install.c:1548 #15 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x5555555768d0) at src/install/dracut-install.c:1554 #16 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557d750) at src/install/dracut-install.c:1548 #17 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555557e700) at src/install/dracut-install.c:1554 #18 0x000055555555bf1c in install_dependent_modules (modlist=0x55555557de90) at src/install/dracut-install.c:1548 #19 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555581c90) at src/install/dracut-install.c:1554 #20 0x000055555555bf1c in install_dependent_modules (modlist=0x555555571e60) at src/install/dracut-install.c:1548 #21 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555556b620) at src/install/dracut-install.c:1554 #22 0x000055555555bf1c in install_dependent_modules (modlist=0x555555583000) at src/install/dracut-install.c:1548 #23 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x55555556b640) at src/install/dracut-install.c:1554 #24 0x000055555555bf1c in install_dependent_modules (modlist=0x555555571b40) at src/install/dracut-install.c:1548 #25 0x000055555555c034 in install_dependent_modules (modlist=modlist@entry=0x555555574100) at src/install/dracut-install.c:1554 #26 0x000055555555c4b0 in install_module (mod=mod@entry=0x555555573bc0) at src/install/dracut-install.c:1617 #27 0x000055555555c93d in install_modules (argc=argc@entry=1, argv=argv@entry=0x7fffffffd6e0) at src/install/dracut-install.c:1952 #28 0x000055555555862a in main (argc=<optimized out>, argv=0x7fffffffd6a8) at src/install/dracut-install.c:2090 Signed-off-by: runsisi <runsisi@hust.edu.cn>
bdrung
added a commit
to bdrung/dracut
that referenced
this pull request
Nov 14, 2023
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI: ``` $ dmesg input: Apple SPI Keyboard as /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-APP000D:00/input/input4 ``` The SPI controller requires the `intel_lpss_pci` kernel module: ``` $ lspci -vv 00:1e.3 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO SPI Controller dracutdevs#1 (rev 21) Subsystem: Intel Corporation Sunrise Point-LP Serial IO SPI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin D routed to IRQ 23 Region 0: Memory at 9282c000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] Vendor Specific Information: Len=14 <?> Kernel driver in use: intel-lpss Kernel modules: intel_lpss_pci ``` Fedora builds `intel_lpss_pci` into the kernel: ``` $ grep INTEL_LPSS_PCI /lib/modules/6.5.11-300.fc39.x86_64/config CONFIG_MFD_INTEL_LPSS_PCI=y ``` But Ubuntu builds `intel_lpss_pci` only as module: ``` $ grep INTEL_LPSS_PCI /boot/config-6.5.0-10-generic CONFIG_MFD_INTEL_LPSS_PCI=m ``` So explicitly include `intel_lpss_pci` to support the keyboard. Bug-Ubuntu: https://launchpad.net/bugs/2042710 fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards") Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
ReillyBrogan
pushed a commit
to getsolus/dracut
that referenced
this pull request
May 18, 2024
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI: ``` $ dmesg input: Apple SPI Keyboard as /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-APP000D:00/input/input4 ``` The SPI controller requires the `intel_lpss_pci` kernel module: ``` $ lspci -vv 00:1e.3 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO SPI Controller dracutdevs#1 (rev 21) Subsystem: Intel Corporation Sunrise Point-LP Serial IO SPI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin D routed to IRQ 23 Region 0: Memory at 9282c000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] Vendor Specific Information: Len=14 <?> Kernel driver in use: intel-lpss Kernel modules: intel_lpss_pci ``` Fedora builds `intel_lpss_pci` into the kernel: ``` $ grep INTEL_LPSS_PCI /lib/modules/6.5.11-300.fc39.x86_64/config CONFIG_MFD_INTEL_LPSS_PCI=y ``` But Ubuntu builds `intel_lpss_pci` only as module: ``` $ grep INTEL_LPSS_PCI /boot/config-6.5.0-10-generic CONFIG_MFD_INTEL_LPSS_PCI=m ``` So explicitly include `intel_lpss_pci` to support the keyboard. Bug-Ubuntu: https://launchpad.net/bugs/2042710 fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards") Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.