-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Actions #840
Draft
ejgallego
wants to merge
8
commits into
main
Choose a base branch
from
codeAction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Code Actions #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
codeAction
branch
from
September 29, 2024 13:05
31b0367
to
b56c2a8
Compare
ejgallego
added
kind: enhancement
New feature or request
part: lsp server
part: protocol (LSP)
kind: upstream
needs: changes entry
kind: HCI design
part: upstream
part: Coq API
labels
Sep 29, 2024
ejgallego
force-pushed
the
codeAction
branch
6 times, most recently
from
September 30, 2024 10:44
516af88
to
643654a
Compare
ejgallego
force-pushed
the
codeAction
branch
3 times, most recently
from
September 30, 2024 19:43
38ed6c6
to
f1c068f
Compare
Not sure I'm happy about the impact of this, but not sure either how to make it more minimal. Some more abstraction w.r.t. async events would be welcome, the error / diagnostic separation as of now either is not super user-friendly.
ejgallego
force-pushed
the
codeAction
branch
from
September 30, 2024 20:03
f1c068f
to
3a3b621
Compare
Just a nit really.
ejgallego
force-pushed
the
codeAction
branch
from
September 30, 2024 20:14
3a3b621
to
556df05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide primitive support for the
textDocument/codeAction
request, for Coq's quickfixes (c.f. coq/coq#19147 )In particular, we now store the quickfix metadata that Coq may send in the diagnostics extra data, which is then queried by the request handler.
This should not provide a lot of overhead but beware.
We introduce a new kind of
Inmediate
request, this should help withcodeAction
and fordocumentSymbol
when in non continuous mode. c.f. #816This opens again the question about why errors are processed specially w.r.t. other async data like
feedback
.This would IMHO require a greater intervention upstream.