[lang] Move Lang.Diagnostics.Data.t from a list to name field
#843
Conversation
This fits our use case better.
| - [lsp] [diagnostics] (! breaking change) change type of diagnostics | ||
| extra data from list to named record (@ejgallego, #843) |
There was a problem hiding this comment.
I think these should be in a separate subsection of the changelog near the top with the title "Breaking changes".
There was a problem hiding this comment.
Indeed, we haven't been too formal as we considered the 0.1.x series not stable at all, we can try to improve in the 0.2.x series, but I think 0.3.x (which could become a kind of 1.0 beta) could enforce this more strictly.
There was a problem hiding this comment.
I noted this in the changelog because I know water proof is using sentenceRange. Also because this change was important moving forward with stuff like #840
There was a problem hiding this comment.
For now we can keep things like now, as tweaking the changes entry will break some tooling, and make a note in the release notes. I skipped the 0.2.0 release notes as this was mostly a "beta".
This fits our use case better.