Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending keys through keygen #268

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Allow extending keys through keygen #268

merged 7 commits into from
Sep 25, 2019

Conversation

kelindar
Copy link
Contributor

This adds a way to extend keys through a normal keygen method. Users will need to provide a key which has extend permissions in the request along with the desired access permissions. Note that the permissions will be a reflection of the key itself (e.g: if a key has re permissions and keygen request contains wr, the resulting key will only have r permission).

@coveralls
Copy link

coveralls commented Sep 15, 2019

Coverage Status

Coverage increased (+0.9%) to 91.381% when pulling ca73d7e on feat-keygen into d3b208d on master.

Copy link
Member

@Florimond Florimond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelindar kelindar merged commit 7c6b3ed into master Sep 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-keygen branch September 25, 2019 10:38
Florimond pushed a commit that referenced this pull request Sep 7, 2023
This adds a way to extend keys through a normal `keygen` method. Users will need to provide a key which has `extend` permissions in the request along with the desired access permissions. Note that the permissions will be a reflection of the key itself (e.g: if a key has `re` permissions and `keygen` request contains `wr`, the resulting key will only have `r` permission).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants