Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CreatePrivateLink from tests and docs #31

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

gmlewis
Copy link
Contributor

@gmlewis gmlewis commented Jan 26, 2021

In b0d1a89 the CreatePrivateLink method was removed but other references were left in. This PR removes them to reduce confusion.

@kelindar kelindar merged commit 9d80ac9 into emitter-io:master Feb 1, 2021
@gmlewis
Copy link
Contributor Author

gmlewis commented Feb 1, 2021

Thank you, @kelindar !

I'm confused now how to make a private one-to-one sub-channel now. Can you please point me to how this is now performed? Is it just a generic "Link" now?

@gmlewis gmlewis deleted the fix-tests-and-docs branch February 1, 2021 16:25
@kelindar
Copy link
Contributor

kelindar commented Feb 1, 2021

@gmlewis the functionality is now supported by the keygen method itself. Have a look at this issue: emitter-io/emitter#264 and PR emitter-io/emitter#268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants