fix(website): APITable component should navigate to anchor less agres…

…sively (#10534) Co-authored-by: Flix <flixy121@gmail.com> Co-authored-by: sebastien <lorber.sebastien@gmail.com>
facebook · Oct 3, 2024 · 7f6472a · 7f6472a
1 parent e8545b5
commit 7f6472a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/website/src/components/APITable/index.tsx b/website/src/components/APITable/index.tsx
@@ -58,9 +58,12 @@ function APITableRow(
       tabIndex={0}
       ref={history.location.hash === anchor ? ref : undefined}
       onClick={(e) => {
-        const isLinkClick =
-          (e.target as HTMLElement).tagName.toUpperCase() === 'A';
-        if (!isLinkClick) {
+        const isTDClick =
+          (e.target as HTMLElement).tagName.toUpperCase() === 'TD';
+        const hasSelectedText = !!window.getSelection()?.toString();
+
+        const shouldNavigate = isTDClick && !hasSelectedText;
+        if (shouldNavigate) {
           history.push(anchor);
         }
       }}

diff --git a/website/src/components/APITable/styles.module.css b/website/src/components/APITable/styles.module.css
@@ -20,3 +20,7 @@
   cursor: pointer;
   transition: box-shadow 0.2s;
 }
+
+.apiTable code {
+  cursor: text;
+}