Warning about failure to build an APK due to poor formatting #14787
Conversation
If you copy and paste the lines gradle.properties into your editor trailing spaces will cause the process to generate the release APK to fail during signing. This warning will help people avoid this problem.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@andre-lima I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
Summary: This sync includes the following changes: - **[f24a0da6e](facebook/react@f24a0da6e )**: Fix useImperativeHandle to have no deps by default (facebook#14801) //<Dan Abramov>// - **[1fecba923](facebook/react@1fecba923 )**: Fix crash unmounting an empty Portal (facebook#14820) //<Dan Abramov>// - **[c11015ff4](facebook/react@c11015ff4 )**: fix spelling mistakes (facebook#14805) //<zhuoli99>// - **[3e295edd5](facebook/react@3e295edd5 )**: Typo fix in comment (facebook#14787) //<Deniz Susman>// - **[1d48b4a68](facebook/react@1d48b4a68 )**: Fix hydration with createRoot warning (facebook#14808) //<Sebastian Markbåge>// Release Notes: [GENERAL] [Changed] - React sync for revisions aa94237...f24a0da Reviewed By: cpojer Differential Revision: D14030552 fbshipit-source-id: f8df9d8e532b2afef59dbbc10715bd52fd22b355
If you copy and paste the lines gradle.properties into your editor trailing spaces will cause the process to generate the release APK to fail during signing. This warning will help people avoid this problem.