Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native link and react-native unlink update. #14801

Closed
wants to merge 2 commits into from
Closed

react-native link and react-native unlink update. #14801

wants to merge 2 commits into from

Conversation

iineva
Copy link
Contributor

@iineva iineva commented Jul 2, 2017

  1. Fix bug: Android project do not delete font files when run react-native unlink.
  2. Add feature, link images to iOS project when run react-native link.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 2, 2017
@grabbou
Copy link
Contributor

grabbou commented Jul 4, 2017

CC: @Kureev

@facebook-github-bot
Copy link
Contributor

@iineva I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@grabbou
Copy link
Contributor

grabbou commented Sep 17, 2017

ping @Kureev

Kureev
Kureev reviewed Sep 18, 2017
View reviewed changes
Copy link
Contributor

@Kureev Kureev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! The code looks good, although I have one question: what do you mean by "linking images"?

@iineva
Copy link
Contributor Author

iineva commented Sep 19, 2017

in this case: https://github.com/iineva/react-native-gpuimage
this lib include some image files, but you can't works well in you project if you don't "linking images".

@Kureev
Copy link
Contributor

Kureev commented Sep 19, 2017

Oh, I see. Interesting case, don't see any reason why we shouldn't merge it 👍

@Kureev
Copy link
Contributor

Kureev commented Sep 19, 2017

If you're agree, @grabbou, lets ship it! 🚢

@grabbou
Copy link
Contributor

grabbou commented Sep 21, 2017

Yeah, conceptually I agree. Didn't have time to test, but code looks good. If you @Kureev are happy code wise, ship it!

@Kureev
Copy link
Contributor

Kureev commented Sep 22, 2017

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Sep 22, 2017
@facebook-github-bot
Copy link
Contributor

@Kureev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Kureev
Copy link
Contributor

Kureev commented Sep 22, 2017

Thank you for your contribution, @iineva! ❤️

@iineva
Copy link
Contributor Author

iineva commented Sep 22, 2017

@Kureev @grabbou Thanks for your great job. 👍

grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@iineva @facebook-github-bot
react-native link and react-native unlink update.
2281ffd 
Summary:
1. Fix bug: Android project do not delete font files when run `react-native unlink`.
2. Add feature, link images to iOS project when run `react-native link`.
Closes facebook/react-native#14801

Differential Revision: D5890051

Pulled By: hramos

fbshipit-source-id: 28223d181ac5ed51d70df29a56eb56b2cce9aecb
pull bot pushed a commit to Rachelmorrell/react-native that referenced this pull request Feb 11, 2019
@hramos @facebook-github-bot
React sync for revisions aa94237...f24a0da
2af13b4 
Summary:
This sync includes the following changes:
- **[f24a0da6e](facebook/react@f24a0da6e )**: Fix useImperativeHandle to have no deps by default (facebook#14801) //<Dan Abramov>//
- **[1fecba923](facebook/react@1fecba923 )**: Fix crash unmounting an empty Portal (facebook#14820) //<Dan Abramov>//
- **[c11015ff4](facebook/react@c11015ff4 )**: fix spelling mistakes (facebook#14805) //<zhuoli99>//
- **[3e295edd5](facebook/react@3e295edd5 )**: Typo fix in comment (facebook#14787) //<Deniz Susman>//
- **[1d48b4a68](facebook/react@1d48b4a68 )**: Fix hydration with createRoot warning (facebook#14808) //<Sebastian Markbåge>//

Release Notes:
[GENERAL] [Changed] - React sync for revisions aa94237...f24a0da

Reviewed By: cpojer

Differential Revision: D14030552

fbshipit-source-id: f8df9d8e532b2afef59dbbc10715bd52fd22b355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kureev Kureev Kureev approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iineva @grabbou @facebook-github-bot @Kureev