[Upload video API] Add forkid option and fix many issue when upload video #175
Conversation
+ add forkid option when upload + reduce timeout when create video + fix upload limit can't detect + remove default title before assign new title + change when remove text func when typing title and description + upload dependencies
Vulnerable Libraries (1)
More info on how to fix Vulnerable Libraries in JavaScript. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
hotrungnhan
changed the title
hotrungnhan
changed the title
|
@hotrungnhan Thanks for this PR, could you please reply to this and this . |
+ add restriction option
renovate.json
Outdated
| { | ||
| "extends": [ | ||
| "config:base" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Why is that file gone now ?
| // await page.keyboard.down('Control') | ||
| // await page.keyboard.press('A') | ||
| // await page.keyboard.up('Control') | ||
| // await page.keyboard.press('Backspace') | ||
| await textBoxes[0].evaluate(e => (e as any).__shady_native_textContent = "") | ||
| await textBoxes[0].type(title.substring(0, maxTitleLen)) | ||
| } | ||
| // Edit the Description content (if) | ||
| if (description) { | ||
| await textBoxes[1].focus() | ||
| await page.keyboard.down('Control') | ||
| await page.keyboard.press('A') | ||
| await page.keyboard.up('Control') | ||
| await page.keyboard.press('Backspace') | ||
| // await textBoxes[1].focus() | ||
| // await page.keyboard.down('Control') | ||
| // await page.keyboard.press('A') | ||
| // await page.keyboard.up('Control') | ||
| // await page.keyboard.press('Backspace') | ||
| await textBoxes[1].evaluate(e => (e as any).__shady_native_textContent = "") |
There was a problem hiding this comment.
This code got commented.
Is that on purpose ?
Either code is useful and we keep it, either it's useless and we remove it and explain why.
There was a problem hiding this comment.
sorry, I forget to explain. That this shortcut unreasonably does not work to clear all the existing text (default video title). that must be replaced with the below
await textBoxes[1].evaluate(e => (e as any).__shady_native_textContent = "")
There was a problem hiding this comment.
then we should prob delete the other lines rather than commenting them :P
|
@hotrungnhan , if you have tested this PR, please let me know. I will merge this PR. |
Hold on i still not done. This is my commit just to update in my fork repo. |
|
@pierreminiggio check it one more time and we can merge @fawazahmed0 . |
|
Thanks |
I only use upload video api, hope some body add these thing for edit metadata and other api....
This change is