Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upload video API] Add forkid option and fix many issue when upload video #175

Merged
merged 6 commits into from
Jan 6, 2023
Merged

[Upload video API] Add forkid option and fix many issue when upload video #175

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
619cf4c
video required make for kids
hotrungnhan Dec 10, 2022
4461b00
update and fix many when upload video
hotrungnhan Dec 10, 2022
c05175e
remove yarn lock
hotrungnhan Jan 1, 2023
557cc37
update typed
hotrungnhan Jan 6, 2023
15d1fd9
revert renovated
hotrungnhan Jan 6, 2023
e8c345b
update better selection
hotrungnhan Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions renovate.json
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export interface Video {
onProgress?: (arg0: VideoProgress) => void
channelName?: string
uploadAsDraft?: boolean
isRestriction?: boolean
hotrungnhan marked this conversation as resolved.
Show resolved Hide resolved
isKid?: boolean
}

export interface MessageTransport {
Expand Down Expand Up @@ -44,6 +46,8 @@ export interface VideoToEdit {
publishType?: 'private' | 'unlisted' | 'public' | 'public&premiere'
onSuccess?: Function
channelName: string
isRestriction?: boolean
isKid?: boolean
}

export interface Comment {
Expand Down
153 changes: 88 additions & 65 deletions src/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Credentials, Video, VideoToEdit, Comment, VideoProgress, ProgressEnum, MessageTransport } from './types'
import puppeteer, { PuppeteerExtra } from 'puppeteer-extra'
import { Puppeteer, PuppeteerNode, PuppeteerNodeLaunchOptions, Browser, Page, errors, PuppeteerErrors } from 'puppeteer'
import puppeteer from 'puppeteer-extra'
import { PuppeteerNodeLaunchOptions, Browser, Page } from 'puppeteer'
import fs from 'fs-extra'
import path from 'path'

Expand All @@ -20,7 +20,7 @@ let browser: Browser, page: Page
let cookiesDirPath: string
let cookiesFilePath: string

const invalidCharacters = [ '<', '>' ]
const invalidCharacters = ['<', '>']

const uploadURL = 'https://www.youtube.com/upload'
const homePageURL = 'https://www.youtube.com'
Expand Down Expand Up @@ -81,7 +81,7 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
throw new Error(`"${videoJSON.title}" includes a character not allowed in youtube titles (${invalidCharacters[i]})`)

if (videoJSON.channelName) {
await changeChannel(videoJSON.channelName);
await changeChannel(videoJSON.channelName);
}

const title = videoJSON.title
Expand All @@ -102,14 +102,14 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
const saveCloseBtnXPath = '//*[@aria-label="Save and close"]/tp-yt-iron-icon'
const createBtnXPath = '//*[@id="create-icon"]/tp-yt-iron-icon'
const addVideoBtnXPath = '//*[@id="text-item-0"]/ytcp-ve/div/div/yt-formatted-string'
if((await page.waitForXPath(createBtnXPath).catch(() => null))){
const createBtn = await page.$x(createBtnXPath);
await createBtn[0].click();
}
if((await page.waitForXPath(addVideoBtnXPath).catch(() => null))){
const addVideoBtn =await page.$x(addVideoBtnXPath);
await addVideoBtn[0].click();
}
if ((await page.waitForXPath(createBtnXPath, { timeout: 5000 }).catch(() => null))) {
const createBtn = await page.$x(createBtnXPath);
await createBtn[0].click();
}
if ((await page.waitForXPath(addVideoBtnXPath, { timeout: 5000 }).catch(() => null))) {
const addVideoBtn = await page.$x(addVideoBtnXPath);
await addVideoBtn[0].click();
}
for (let i = 0; i < 2; i++) {
try {
await page.waitForXPath(selectBtnXPath)
Expand Down Expand Up @@ -137,7 +137,6 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
selectBtn[0].click() // button that triggers file selection
])
await fileChooser.accept([pathToFile])

// Setup onProgress
let progressChecker: any
let progress: VideoProgress = { progress: 0, stage: ProgressEnum.Uploading };
Expand All @@ -154,34 +153,32 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
if (progressChecker == undefined || !curProgress) return
curProgress = curProgress.split(" ").find((txt: string) => txt.indexOf("%") != -1)
let newProgress = curProgress ? parseInt(curProgress.slice(0, -1)) : 0
if ( progress.progress == newProgress ) return
if (progress.progress == newProgress) return
progress.progress = newProgress
videoJSON.onProgress!(progress)
}, 500)
}

const errorMessage = await page.evaluate(() => (document.querySelector('.error-area.style-scope.ytcp-uploads-dialog') as HTMLElement)?.innerText.trim())

if (errorMessage) {
await browser.close()
throw new Error('Youtube returned an error : ' + errorMessage)
}

// Wait for upload to complete
const uploadCompletePromise = page.waitForXPath('//*[contains(text(),"Upload complete")]', { timeout: 0 }).then(() => 'uploadComplete')
const uploadCompletePromise = page.waitForXPath('//tp-yt-paper-progress[contains(@class,"ytcp-video-upload-progress-hover") and @value="100"]', { timeout: 0 }).then(() => 'uploadComplete')
hotrungnhan marked this conversation as resolved.
Show resolved Hide resolved

// Check if daily upload limit is reached
const dailyUploadPromise = page.waitForXPath('//*[contains(text(),"Daily upload limit reached")]', { timeout: 0 }).then(() => 'dailyUploadReached');

const dailyUploadPromise = page.waitForXPath('//div[contains(text(),"Daily upload limit reached")]', { timeout: 0 }).then(() => 'dailyUploadReached');
const uploadResult = await Promise.any([uploadCompletePromise, dailyUploadPromise])
if (uploadResult === 'dailyUploadReached') {
await browser.close();
browser.close();
throw new Error('Daily upload limit reached');
}

// Wait for upload to go away and processing to start, skip the wait if the user doesn't want it.
if (!videoJSON.skipProcessingWait) {
await page.waitForXPath('//*[contains(text(),"Upload complete")]', { hidden: true, timeout: 0 })
await page.waitForXPath('//*[contains(text(),"Video upload complete")]', { hidden: true, timeout: 0 })
hotrungnhan marked this conversation as resolved.
Show resolved Hide resolved
} else {
await sleep(5000)
}
Expand All @@ -190,14 +187,23 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
progress = { progress: 0, stage: ProgressEnum.Processing }
videoJSON.onProgress(progress)
}

if (videoJSON.onProgress) {
clearInterval(progressChecker)
progressChecker = undefined
progress = { progress: 100, stage: ProgressEnum.Done }
videoJSON.onProgress(progress)
}

if (!videoJSON.isKid) {
await page.click("tp-yt-paper-radio-button[name='VIDEO_MADE_FOR_KIDS_MFK']").catch()
} else {
await page.click("tp-yt-paper-radio-button[name='VIDEO_MADE_FOR_KIDS_NOT_MFK']").catch()
}

if (!videoJSON.isRestriction) {
await page.click("tp-yt-paper-radio-button[name='VIDEO_AGE_RESTRICTION_SELF']").catch()
}

// Wait until title & description box pops up
if (thumb) {
let thumbnailChooserXpath = xpathTextSelector("upload thumbnail")
Expand All @@ -209,20 +215,21 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
])
await thumbChooser.accept([thumb])
}

await page.waitForFunction('document.querySelectorAll(\'[id="textbox"]\').length > 1')
const textBoxes = await page.$x('//*[@id="textbox"]')
await page.bringToFront()
// Add the title value
await textBoxes[0].focus()
await page.waitForTimeout(1000)
await textBoxes[0].evaluate(e => (e as any).__shady_native_textContent = "")
await textBoxes[0].type(title.substring(0, maxTitleLen))
// Add the Description content
await textBoxes[0].evaluate(e => (e as any).__shady_native_textContent = "")
await textBoxes[1].type(description.substring(0, maxDescLen))


const childOption = await page.$x('//*[contains(text(),"No, it\'s")]')
await childOption[0].click()

const moreOption = await page.$x("//*[normalize-space(text())='Show more']")
await moreOption[0].click()
const playlist = await page.$x("//*[normalize-space(text())='Select']")
Expand Down Expand Up @@ -265,10 +272,16 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
}
}
}
await page.click("#toggle-button")
// Add tags
if (tags) {
await page.focus(`[aria-label="Tags"]`)
await page.type(`[aria-label="Tags"]`, tags.join(', ').substring(0, 495) + ', ')
//show more
try {
await page.focus(`[aria-label="Tags"]`)
await page.type(`[aria-label="Tags"]`, tags.join(', ').substring(0, 495) + ', ')
} catch (err) {

}
}

// Selecting video language
Expand All @@ -278,8 +291,8 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
// translate(text(),'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')
const langName = await page.$x(
'//*[normalize-space(translate(text(),"ABCDEFGHIJKLMNOPQRSTUVWXYZ","abcdefghijklmnopqrstuvwxyz"))=\'' +
videoLang.toLowerCase() +
"']"
videoLang.toLowerCase() +
"']"
)
await page.evaluate((el) => el.click(), langName[langName.length - 1])
}
Expand All @@ -293,7 +306,6 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
// click next button
next = await page.$x(nextBtnXPath)
await next[0].click()

await page.waitForXPath(nextBtnXPath)
// click next button
next = await page.$x(nextBtnXPath)
Expand All @@ -320,7 +332,7 @@ async function uploadVideo(videoJSON: Video, messageTransport: MessageTransport)
uploadedLink = await page.evaluate((e) => e.getAttribute('href'), uploadedLinkHandle)
} while (uploadedLink === videoBaseLink || uploadedLink === shortVideoBaseLink)

const closeDialogXPath = uploadAsDraft ? saveCloseBtnXPath : publishXPath
const closeDialogXPath = uploadAsDraft ? saveCloseBtnXPath : publishXPath
let closeDialog
for (let i = 0; i < 10; i++) {
try {
Expand Down Expand Up @@ -508,20 +520,31 @@ const updateVideoInfo = async (videoJSON: VideoToEdit, messageTransport: Message
await textBoxes[0].focus()
await page.waitForTimeout(1000)
await sleep(1000)
if (!videoJSON.isKid) {
await page.click("tp-yt-paper-radio-button[name='VIDEO_MADE_FOR_KIDS_MFK']").catch()
} else {
await page.click("tp-yt-paper-radio-button[name='VIDEO_MADE_FOR_KIDS_NOT_MFK']").catch()
}

if (!videoJSON.isRestriction) {
await page.click("tp-yt-paper-radio-button[name='VIDEO_AGE_RESTRICTION_SELF']").catch()
}
if (title) {
await page.keyboard.down('Control')
await page.keyboard.press('A')
await page.keyboard.up('Control')
await page.keyboard.press('Backspace')
// await page.keyboard.down('Control')
// await page.keyboard.press('A')
// await page.keyboard.up('Control')
// await page.keyboard.press('Backspace')
await textBoxes[0].evaluate(e => (e as any).__shady_native_textContent = "")
await textBoxes[0].type(title.substring(0, maxTitleLen))
}
// Edit the Description content (if)
if (description) {
await textBoxes[1].focus()
await page.keyboard.down('Control')
await page.keyboard.press('A')
await page.keyboard.up('Control')
await page.keyboard.press('Backspace')
// await textBoxes[1].focus()
// await page.keyboard.down('Control')
// await page.keyboard.press('A')
// await page.keyboard.up('Control')
// await page.keyboard.press('Backspace')
await textBoxes[1].evaluate(e => (e as any).__shady_native_textContent = "")
Comment on lines +528 to +542
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code got commented.
Is that on purpose ?
Either code is useful and we keep it, either it's useless and we remove it and explain why.

Copy link
Contributor Author

@hotrungnhan hotrungnhan Jan 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I forget to explain. That this shortcut unreasonably does not work to clear all the existing text (default video title). that must be replaced with the below
await textBoxes[1].evaluate(e => (e as any).__shady_native_textContent = "")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we should prob delete the other lines rather than commenting them :P

await textBoxes[1].type(description.substring(0, maxDescLen))
}
if (thumb) {
Expand Down Expand Up @@ -595,8 +618,8 @@ const updateVideoInfo = async (videoJSON: VideoToEdit, messageTransport: Message
await page.evaluate((el) => el.click(), langHandler[0])
const langName = await page.$x(
'//*[normalize-space(translate(text(),"ABCDEFGHIJKLMNOPQRSTUVWXYZ","abcdefghijklmnopqrstuvwxyz"))=\'' +
videoLang.toLowerCase() +
"']"
videoLang.toLowerCase() +
"']"
)
await page.evaluate((el) => el.click(), langName[langName.length - 1])
}
Expand Down Expand Up @@ -843,7 +866,7 @@ async function login(localPage: Page, credentials: Credentials, messageTransport
await localPage.waitForSelector(passwordInputSelector)
await localPage.waitForTimeout(3000)
await localPage.type(passwordInputSelector, credentials.pass, { delay: 50 })

await localPage.keyboard.press('Enter')
}

Expand Down Expand Up @@ -979,59 +1002,59 @@ async function scrollTillVeiw(page: Page, element: string) {
}

async function changeChannel(channelName: string) {
await page.goto("https://www.youtube.com/channel_switcher");
await page.goto("https://www.youtube.com/channel_switcher");

const channelNameXPath =
`//*[normalize-space(text())='${channelName}']`;
const element = await page.waitForXPath(channelNameXPath);
const channelNameXPath =
`//*[normalize-space(text())='${channelName}']`;
const element = await page.waitForXPath(channelNameXPath);

await element!.click()
await element!.click()

await page.waitForNavigation({
waitUntil: "networkidle0"
});
await page.waitForNavigation({
waitUntil: "networkidle0"
});
}

function escapeQuotesForXPath(str: string) {
// If the value contains only single or double quotes, construct
// an XPath literal
if (!str.includes('"')){
if (!str.includes('"')) {
return '"' + str + '"';
}
if (!str.includes("'")) {
return "'" + str + "'";
}
// If the value contains both single and double quotes, construct an
// If the value contains both single and double quotes, construct an
// expression that concatenates all non-double-quote substrings with
// the quotes, e.g.:
//
// concat("foo",'"',"bar")

const parts : string[] = [];
const parts: string[] = [];
// First, put a '"' after each component in the string.
for (const part of str.split('"')) {
if (part.length > 0) {
parts.push('"' + part + '"');
}
parts.push("'\"'");
}
// Then remove the extra '"' after the last component.
// Then remove the extra '"' after the last component.
parts.pop();
// Finally, put it together into a concat() function call.

return "concat(" + parts.join(",") + ")";
}

function xpathTextSelector( text: string, caseSensitive?: boolean, nthElement?: number ){
function xpathTextSelector(text: string, caseSensitive?: boolean, nthElement?: number) {
let xpathSelector = ''
if(caseSensitive)
xpathSelector = `//*[contains(normalize-space(text()),"${text}")]`
else{
let uniqueText = [...new Set(text.split(''))].join('')
xpathSelector = `//*[contains(translate(normalize-space(text()),'${uniqueText.toUpperCase()}','${uniqueText.toLowerCase()}'),"${text.toLowerCase().replace(/\s\s+/g, " ")}")]`
}
if(nthElement)
xpathSelector = `(${xpathSelector})[${nthElement+1}]`
if (caseSensitive)
xpathSelector = `//*[contains(normalize-space(text()),"${text}")]`
else {
let uniqueText = [...new Set(text.split(''))].join('')
xpathSelector = `//*[contains(translate(normalize-space(text()),'${uniqueText.toUpperCase()}','${uniqueText.toLowerCase()}'),"${text.toLowerCase().replace(/\s\s+/g, " ")}")]`
}
if (nthElement)
xpathSelector = `(${xpathSelector})[${nthElement + 1}]`

return xpathSelector
}
}