Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter] Add support for marker clustering - platform interface #6158

Conversation

jokerttu
Copy link
Contributor

This PR introduces support for marker clustering

This is prequel PR for: #4319
Containing only changes to google_maps_flutter_platform_interface package.

Follow up PR:s will hold the platform and app-facing plugin implementations.

Linked issue: flutter/flutter#26863

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu force-pushed the feature/google_maps_flutter_platform_interface_marker_clustering branch from 14096cb to 4df8b06 Compare February 29, 2024 08:15
@jokerttu
Copy link
Contributor Author

Rebased and version number updated from 2.5.0 to 2.6.0

@jokerttu jokerttu changed the title [google_maps_flutter_platform_interface] Add support for marker clustering [google_maps_flutter] Add support for marker clustering - platform interface Feb 29, 2024
@stuartmorgan
Copy link
Contributor

This has approval, so you can add the autosubmit label any time.

@jokerttu
Copy link
Contributor Author

This has approval, so you can add the autosubmit label any time.

@stuartmorgan This need to be done by someone who has permissions to add labels.

@stuartmorgan
Copy link
Contributor

I can add it, but you're showing as an org member so you should be able to add labels. If that's not working there's a configuration problem somewhere, so please follow up in #server-support on Discord.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
Copy link
Contributor

auto-submit bot commented Feb 29, 2024

auto label is removed for flutter/packages/6158, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@stuartmorgan
Copy link
Contributor

Well now I'm very confused.

@stuartmorgan
Copy link
Contributor

Oh I see, you're a member of Flutter, but not flutter-hackers. I'm not sure how that happened.

@stuartmorgan
Copy link
Contributor

I've nominated you for full access, so once you confirm in Discord we'll be able to land this with the one review :)

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@auto-submit auto-submit bot merged commit b3f10aa into flutter:main Feb 29, 2024
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 1, 2024
flutter/packages@6d02f03...a9c68b8

2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/packages#6234)
2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232)
2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a to 7482962 (1 revision) (flutter/packages#6230)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe8 to e92bca3 (15 revisions) (flutter/packages#6227)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
…terface (flutter#6158)

This PR introduces support for marker clustering

This is prequel PR for: flutter#4319
Containing only changes to `google_maps_flutter_platform_interface` package.

Follow up PR:s will hold the platform and app-facing plugin implementations.

Linked issue: flutter/flutter#26863
jokerttu added a commit that referenced this pull request Apr 30, 2024
This PR introduces support for marker clustering for Android platform

An example usage is available in the example application at
`./packages/google_maps_flutter/google_maps_flutter_android/example` on
the page `Manage clustering`

This is prequel PR for: #4319
and sequel PR for: #6158

Containing only changes to `google_maps_flutter_android` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863
jokerttu added a commit that referenced this pull request Apr 30, 2024
This PR introduces support for marker clustering for Web platform

This is prequel PR for: #4319
and sequel PR for: #6158

Containing only changes to `google_maps_flutter_web` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863

---------

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…6185)

This PR introduces support for marker clustering for Android platform

An example usage is available in the example application at
`./packages/google_maps_flutter/google_maps_flutter_android/example` on
the page `Manage clustering`

This is prequel PR for: flutter#4319
and sequel PR for: flutter#6158

Containing only changes to `google_maps_flutter_android` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
This PR introduces support for marker clustering for Web platform

This is prequel PR for: flutter#4319
and sequel PR for: flutter#6158

Containing only changes to `google_maps_flutter_web` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863

---------

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…terface (flutter#6158)

This PR introduces support for marker clustering

This is prequel PR for: flutter#4319
Containing only changes to `google_maps_flutter_platform_interface` package.

Follow up PR:s will hold the platform and app-facing plugin implementations.

Linked issue: flutter/flutter#26863
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…6185)

This PR introduces support for marker clustering for Android platform

An example usage is available in the example application at
`./packages/google_maps_flutter/google_maps_flutter_android/example` on
the page `Manage clustering`

This is prequel PR for: flutter#4319
and sequel PR for: flutter#6158

Containing only changes to `google_maps_flutter_android` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
This PR introduces support for marker clustering for Web platform

This is prequel PR for: flutter#4319
and sequel PR for: flutter#6158

Containing only changes to `google_maps_flutter_web` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863

---------

Co-authored-by: David Iglesias Teixeira <ditman@gmail.com>
auto-submit bot pushed a commit that referenced this pull request Aug 6, 2024
…ion (#6186)

This PR introduces support for marker clustering for iOS platform

An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering`

This is prequel PR for: #4319
and sequel PR for: #6158

Containing only changes to `google_maps_flutter_ios` package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: flutter/flutter#26863
@jokerttu jokerttu deleted the feature/google_maps_flutter_platform_interface_marker_clustering branch September 9, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants